Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs ] Fix typo: step() -> act() #128

Merged
merged 1 commit into from
Jun 15, 2019
Merged

[Docs ] Fix typo: step() -> act() #128

merged 1 commit into from
Jun 15, 2019

Conversation

RicCu
Copy link
Contributor

@RicCu RicCu commented Jun 15, 2019

Motivation and Context

Current docs for habitat.Agent point to implement nonexistent method step() instead of act().

How Has This Been Tested

No testing

Types of changes

  • Docs change / refactoring / dependency upgrade

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 15, 2019
@erikwijmans erikwijmans requested a review from abhiskk June 15, 2019 05:25
mathfac
mathfac approved these changes Jun 15, 2019
View reviewed changes
Copy link
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it.

@mathfac mathfac merged commit af32b4c into facebookresearch:master Jun 15, 2019
dhruvbatra pushed a commit that referenced this pull request May 10, 2020
@abhiskk
Update README.md (#128)
8ddc21f
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@RicCu @mathfac
Fix docs typo: step() -> act() (facebookresearch#128)
02c51d8 
Fix docs typo: step() -> act()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathfac mathfac mathfac approved these changes

@abhiskk abhiskk Awaiting requested review from abhiskk

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RicCu @mathfac @facebook-github-bot