Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add a OffloadConfig object to specify offloading params to disk. #855

Merged
merged 5 commits into from
Nov 17, 2021

Conversation

anj-s
Copy link
Contributor

@anj-s anj-s commented Nov 17, 2021

What does this PR do?

Added a new class that will encompass (eventually) all parameters required for specifying offloading for FSDP. Currently we add to a list of parameters which is ever growing. This is an attempt to simplify the API and account for more knobs for given features.

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 17, 2021
@anj-s anj-s marked this pull request as draft November 17, 2021 20:58
@anj-s anj-s marked this pull request as ready for review November 17, 2021 21:42
Copy link
Contributor

@min-xu-ai min-xu-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming no logic changes.

@anj-s
Copy link
Contributor Author

anj-s commented Nov 17, 2021

LGTM assuming no logic changes.

None! Just addressing the two comments from the previous PR: removing kwargs and adding a config object + using tempfile utilities.

@anj-s anj-s merged commit ef194cd into main Nov 17, 2021
@anj-s anj-s deleted the fsdp-api branch November 17, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants