Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Update Sphinx version in docs requirements file #841

Merged
merged 1 commit into from
Nov 3, 2021
Merged

[chore] Update Sphinx version in docs requirements file #841

merged 1 commit into from
Nov 3, 2021

Conversation

vtantia
Copy link
Contributor

@vtantia vtantia commented Nov 3, 2021 •
edited
Loading

What does this PR do?

  • Updates sphinx version in docs requirements file to ensure we can use napoleon_custom_sections which shall be needed in this PR.

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2021
blefaudeux
blefaudeux approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@blefaudeux blefaudeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the doc built properly, LGTM !

@min-xu-ai
Copy link
Contributor

Thanks for the update. it seems to trigger a flaky test. I triggered a rerun.

@min-xu-ai min-xu-ai merged commit f327eb4 into facebookresearch:main Nov 3, 2021
@vtantia vtantia deleted the upgrade_sphinx branch November 3, 2021 21:50
@vtantia
Copy link
Contributor Author

vtantia commented Nov 3, 2021 •
edited
Loading

Thanks @blefaudeux for the review. Thanks @min-xu-ai for taking care of the flaky test and merging the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blefaudeux blefaudeux blefaudeux approved these changes

@tmarkstrum tmarkstrum Awaiting requested review from tmarkstrum

@min-xu-ai min-xu-ai Awaiting requested review from min-xu-ai

@anj-s anj-s Awaiting requested review from anj-s

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtantia @min-xu-ai @blefaudeux @facebook-github-bot