Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Skip creating the CPU grad tensor when training #821

Merged
merged 4 commits into from
Oct 27, 2021
Merged

[feature] Skip creating the CPU grad tensor when training #821

merged 4 commits into from
Oct 27, 2021

Conversation

anj-s
Copy link
Contributor

@anj-s anj-s commented Oct 21, 2021 •
edited
Loading

What does this PR do?

This issue came up when identifying memory consumption for CPU offload. We create a CPU grad tensor at the beginning of the FW pass for every parameter even during eval. By skipping this, we save memory roughly equal to that of the parameters.

I don't think this change should have any negative effects given that we reset params at the beginning of FW but let me know if I haven't thought of a corner case. Thanks!

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2021
@anj-s anj-s requested a review from min-xu-ai October 21, 2021 12:21
min-xu-ai
min-xu-ai approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@min-xu-ai min-xu-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. maybe add a short comment in the code if not already covered by existing comment?

@anj-s anj-s merged commit 5f895f0 into main Oct 27, 2021
@anj-s anj-s deleted the skip-cpu-grad-pin branch October 27, 2021 19:08
vtantia pushed a commit that referenced this pull request Oct 29, 2021
@anj-s @vtantia
[feature] Skip creating the CPU grad tensor when training (#821)
2bd31a2 
* skip creating cpu grads and pinning memory

* added additional comment

* pin docutils to fix circleCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@min-xu-ai min-xu-ai min-xu-ai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. FSDP + SSD offload
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anj-s @min-xu-ai @facebook-github-bot