Overhaul logging and deprecate the compiler_gym.util.logs and compiler_gym.replay_search modules #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the create_logs_dir() function into the runfile_path module so that all of the functions for generating filesystem paths are in the same module. This also improves the implementation by enabling thread safe logging directory generation, and renames the function to create_user_logs_dir() to better communicate the type of logs.
facebook-github-bot
added
the
CLA Signed
ChrisCummins
changed the title
Codecov Report
@@ Coverage Diff @@
## development #453 +/- ##
===============================================
+ Coverage 87.53% 87.56% +0.03%
===============================================
Files 109 109
Lines 6047 6113 +66
===============================================
+ Hits 5293 5353 +60
- Misses 754 760 +6
Continue to review full report at Codecov.
|
This aggregates the random search utility classes and functions into the random_search module. This effectively deprecates the compiler_gym.random_replay and compiler_gym.util.logs modules.
This replaces the per-object instances of loggers with a shared per-module logger, accessed using logging.getLogger(__name__). The idea is to improve the consistency of logging.
Always check the Python version and use terminate() on py < 3.7, and always block until the process has actually terminated.
This was referenced Oct 7, 2021
This ensures that the thread pool is destroyed after use.
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this pull request
Oct 11, 2021
ChrisCummins
added a commit
that referenced
this pull request
Nov 8, 2021
This was referenced Nov 17, 2021
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logging.getLogger(__name__).create_logs_dir()function into thecompiler_gym.util.runfile_pathmodule so that all of the functions for generating filesystem paths are in the same module. This also improves the implementation by enabling thread safe logging directory generation, and renames the function tocreate_user_logs_dir()to better communicate the type of logs.