Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ObservationView to reward reset() arguments #341

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Add ObservationView to reward reset() arguments #341

merged 1 commit into from
Jul 27, 2021

Conversation

bwasti
Copy link
Contributor

@bwasti bwasti commented Jul 26, 2021

This PR will enable a Reward's reset method to inspect the observation_view of the environment. For loop_tool this means it can grab the flops observation space.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2021
@ChrisCummins
Copy link
Contributor

Thanks for this @bwasti! It looks like there might be a couple more reset() calls that need updating.

Sorry to be a PITA, but could the arg be called observation_view? This is to keep it consistent with Reward.update().

Cheers,
Chris

@ChrisCummins
Copy link
Contributor

Brilliant, thanks @bwasti! LGTM, merging.

Cheers,
Chris

@ChrisCummins ChrisCummins merged commit f3dd7a8 into facebookresearch:development Jul 27, 2021
@ChrisCummins ChrisCummins deleted the reward_reset branch July 27, 2021 18:34
This was referenced Sep 8, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwasti @ChrisCummins @facebook-github-bot