Port the compiler gym service backends to the new API #277

ChrisCummins · 2021-05-17T19:28:03Z

Issue #254.

hughleat

LGTM, although I still think that not making the user know anything about what RPC mechanism you are using would be better, including allowing a simpler API for them.

examples/example_compiler_gym_service/service_cc/ExampleService.cc

hughleat · 2021-05-18T07:20:56Z

examples/example_compiler_gym_service/service_cc/ExampleService.cc

-}
+  std::vector<ActionSpace> getActionSpaces() const final override {
+    ActionSpace space;
+    space.set_name("default");


Shame these are protobufs, then they could just be params to the constructor.

The problem is that this class is never instantiated by the user. They pass it into CompilerGymService<T> which handles lifetime management:
https://github.com/facebookresearch/CompilerGym/blob/development/compiler_gym/service/runtime/CompilerGymServiceImpl.h#L64

hughleat · 2021-05-18T07:35:58Z

examples/example_compiler_gym_service/env_tests.py

+    scope="module",
+    params=[example.EXAMPLE_CC_SERVICE_BINARY, example.EXAMPLE_PY_SERVICE_BINARY],
+)
+def bin(request) -> Path:


Is this function unused?

@pytest.fixture decorator declares a fixture, which means that any test function can then take bin as an argument and it will run and return the fixture value

ChrisCummins · 2021-05-18T09:58:00Z

Thanks for the review @hughleat!

The CI is complaining of a problem that I've never seen before. An undefined reference to the destructor of google::protobuf::RepeatedPtrField<compiler_gym::ObservationSpace>::~RepeatedPtrField() and google::protobuf::RepeatedPtrField<compiler_gym::ActionSpace>::~RepeatedPtrField() in getSpaces():

bazel-out/k8-fastbuild/bin/examples/_objs/RandomSearch/RandomSearch.pic.o:RandomSearch.cc:function compiler_gym::runtime::CompilerGymService<compiler_gym::llvm_service::LlvmSession>::GetSpaces(grpc::ServerContext*, compiler_gym::GetSpacesRequest const*, compiler_gym::GetSpacesReply*): error: undefined reference to 'google::protobuf::RepeatedPtrField<compiler_gym::ObservationSpace>::~RepeatedPtrField()'

Will investigate and fix before merging.

ChrisCummins · 2021-05-20T13:23:13Z

I have been blocked on this issue for a couple of days now and cannot seem to figure it out. I have been unable to reproduce this locally on any build environment, including the docker environment used for building the linux wheels. The problem affects all targets that use the new C++ CompilerGymService implementation, and produces the same link-time error:

ERROR: /home/runner/work/CompilerGym/CompilerGym/compiler_gym/envs/llvm/service/BUILD:53:10: Linking compiler_gym/envs/llvm/service/compiler_gym-llvm-service-prelinked failed: (Exit 1): clang failed: error executing command 
  (cd /home/runner/.cache/bazel/_bazel_runner/db3e34f1e14ee53d927a48b4c425fcaa/sandbox/linux-sandbox/1570/execroot/CompilerGym && \
  exec env - \
    LD_LIBRARY_PATH=/opt/hostedtoolcache/Python/3.9.5/x64/lib \
    PATH=/home/runner/.cache/bazelisk/downloads/bazelbuild/bazel-4.0.0-linux-x86_64/bin:/opt/hostedtoolcache/Python/3.9.5/x64/bin:/opt/hostedtoolcache/Python/3.9.5/x64:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/home/runner/.local/bin:/opt/pipx_bin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin \
    *** \
  /usr/bin/clang @bazel-out/k8-fastbuild/bin/compiler_gym/envs/llvm/service/compiler_gym-llvm-service-prelinked-2.params)
Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox clang failed: error executing command 
  (cd /home/runner/.cache/bazel/_bazel_runner/db3e34f1e14ee53d927a48b4c425fcaa/sandbox/linux-sandbox/1570/execroot/CompilerGym && \
  exec env - \
    LD_LIBRARY_PATH=/opt/hostedtoolcache/Python/3.9.5/x64/lib \
    PATH=/home/runner/.cache/bazelisk/downloads/bazelbuild/bazel-4.0.0-linux-x86_64/bin:/opt/hostedtoolcache/Python/3.9.5/x64/bin:/opt/hostedtoolcache/Python/3.9.5/x64:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/home/runner/.local/bin:/opt/pipx_bin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin \
    *** \
  /usr/bin/clang @bazel-out/k8-fastbuild/bin/compiler_gym/envs/llvm/service/compiler_gym-llvm-service-prelinked-2.params)
Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox
bazel-out/k8-fastbuild/bin/compiler_gym/envs/llvm/service/_objs/compiler_gym-llvm-service-prelinked/RunService.pic.o:RunService.cc:function compiler_gym::runtime::CompilerGymService<compiler_gym::llvm_service::LlvmSession>::GetSpaces(grpc::ServerContext*, compiler_gym::GetSpacesRequest const*, compiler_gym::GetSpacesReply*): error: undefined reference to 'google::protobuf::RepeatedPtrField<compiler_gym::ActionSpace>::~RepeatedPtrField()'
bazel-out/k8-fastbuild/bin/compiler_gym/envs/llvm/service/_objs/compiler_gym-llvm-service-prelinked/RunService.pic.o:RunService.cc:function compiler_gym::runtime::CompilerGymService<compiler_gym::llvm_service::LlvmSession>::GetSpaces(grpc::ServerContext*, compiler_gym::GetSpacesRequest const*, compiler_gym::GetSpacesReply*): error: undefined reference to 'google::protobuf::RepeatedPtrField<compiler_gym::ObservationSpace>::~RepeatedPtrField()'
bazel-out/k8-fastbuild/bin/compiler_gym/envs/llvm/service/_objs/compiler_gym-llvm-service-prelinked/RunService.pic.o:RunService.cc:function compiler_gym::runtime::CompilerGymService<compiler_gym::llvm_service::LlvmSession>::GetSpaces(grpc::ServerContext*, compiler_gym::GetSpacesRequest const*, compiler_gym::GetSpacesReply*): error: undefined reference to 'google::protobuf::RepeatedPtrField<compiler_gym::ActionSpace>::~RepeatedPtrField()'
bazel-out/k8-fastbuild/bin/compiler_gym/envs/llvm/service/_objs/compiler_gym-llvm-service-prelinked/RunService.pic.o:RunService.cc:function compiler_gym::runtime::CompilerGymService<compiler_gym::llvm_service::LlvmSession>::GetSpaces(grpc::ServerContext*, compiler_gym::GetSpacesRequest const*, compiler_gym::GetSpacesReply*): error: undefined reference to 'google::protobuf::RepeatedPtrField<compiler_gym::ObservationSpace>::~RepeatedPtrField()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

ERROR: /home/runner/work/CompilerGym/CompilerGym/examples/example_compiler_gym_service/service_cc/BUILD:7:10: Linking examples/example_compiler_gym_service/service_cc/compiler_gym-example-service-cc failed: (Exit 1): clang failed: error executing command 
  (cd /home/runner/.cache/bazel/_bazel_runner/db3e34f1e14ee53d927a48b4c425fcaa/sandbox/linux-sandbox/2646/execroot/CompilerGym && \
  exec env - \
    LD_LIBRARY_PATH=/opt/hostedtoolcache/Python/3.9.5/x64/lib \
    PATH=/home/runner/.cache/bazelisk/downloads/bazelbuild/bazel-4.0.0-linux-x86_64/bin:/opt/hostedtoolcache/Python/3.9.5/x64/bin:/opt/hostedtoolcache/Python/3.9.5/x64:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/home/runner/.local/bin:/opt/pipx_bin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin \
    *** \
  /usr/bin/clang @bazel-out/k8-fastbuild/bin/examples/example_compiler_gym_service/service_cc/compiler_gym-example-service-cc-2.params)
Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox clang failed: error executing command 
  (cd /home/runner/.cache/bazel/_bazel_runner/db3e34f1e14ee53d927a48b4c425fcaa/sandbox/linux-sandbox/2646/execroot/CompilerGym && \
  exec env - \
    LD_LIBRARY_PATH=/opt/hostedtoolcache/Python/3.9.5/x64/lib \
    PATH=/home/runner/.cache/bazelisk/downloads/bazelbuild/bazel-4.0.0-linux-x86_64/bin:/opt/hostedtoolcache/Python/3.9.5/x64/bin:/opt/hostedtoolcache/Python/3.9.5/x64:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/home/runner/.local/bin:/opt/pipx_bin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin \
    *** \
  /usr/bin/clang @bazel-out/k8-fastbuild/bin/examples/example_compiler_gym_service/service_cc/compiler_gym-example-service-cc-2.params)
Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox
bazel-out/k8-fastbuild/bin/examples/example_compiler_gym_service/service_cc/_objs/compiler_gym-example-service-cc/ExampleService.pic.o:ExampleService.cc:function compiler_gym::runtime::CompilerGymService<(anonymous namespace)::ExampleCompilationSession>::GetSpaces(grpc::ServerContext*, compiler_gym::GetSpacesRequest const*, compiler_gym::GetSpacesReply*): error: undefined reference to 'google::protobuf::RepeatedPtrField<compiler_gym::ActionSpace>::~RepeatedPtrField()'
bazel-out/k8-fastbuild/bin/examples/example_compiler_gym_service/service_cc/_objs/compiler_gym-example-service-cc/ExampleService.pic.o:ExampleService.cc:function compiler_gym::runtime::CompilerGymService<(anonymous namespace)::ExampleCompilationSession>::GetSpaces(grpc::ServerContext*, compiler_gym::GetSpacesRequest const*, compiler_gym::GetSpacesReply*): error: undefined reference to 'google::protobuf::RepeatedPtrField<compiler_gym::ObservationSpace>::~RepeatedPtrField()'
bazel-out/k8-fastbuild/bin/examples/example_compiler_gym_service/service_cc/_objs/compiler_gym-example-service-cc/ExampleService.pic.o:ExampleService.cc:function compiler_gym::runtime::CompilerGymService<(anonymous namespace)::ExampleCompilationSession>::GetSpaces(grpc::ServerContext*, compiler_gym::GetSpacesRequest const*, compiler_gym::GetSpacesReply*): error: undefined reference to 'google::protobuf::RepeatedPtrField<compiler_gym::ActionSpace>::~RepeatedPtrField()'
bazel-out/k8-fastbuild/bin/examples/example_compiler_gym_service/service_cc/_objs/compiler_gym-example-service-cc/ExampleService.pic.o:ExampleService.cc:function compiler_gym::runtime::CompilerGymService<(anonymous namespace)::ExampleCompilationSession>::GetSpaces(grpc::ServerContext*, compiler_gym::GetSpacesRequest const*, compiler_gym::GetSpacesReply*): error: undefined reference to 'google::protobuf::RepeatedPtrField<compiler_gym::ObservationSpace>::~RepeatedPtrField()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

ERROR: /home/runner/work/CompilerGym/CompilerGym/examples/BUILD:120:10: Linking examples/RandomSearch failed: (Exit 1): clang failed: error executing command 
  (cd /home/runner/.cache/bazel/_bazel_runner/db3e34f1e14ee53d927a48b4c425fcaa/sandbox/linux-sandbox/2798/execroot/CompilerGym && \
  exec env - \
    LD_LIBRARY_PATH=/opt/hostedtoolcache/Python/3.9.5/x64/lib \
    PATH=/home/runner/.cache/bazelisk/downloads/bazelbuild/bazel-4.0.0-linux-x86_64/bin:/opt/hostedtoolcache/Python/3.9.5/x64/bin:/opt/hostedtoolcache/Python/3.9.5/x64:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/home/runner/.local/bin:/opt/pipx_bin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin \
    *** \
  /usr/bin/clang @bazel-out/k8-fastbuild/bin/examples/RandomSearch-2.params)
Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox clang failed: error executing command 
  (cd /home/runner/.cache/bazel/_bazel_runner/db3e34f1e14ee53d927a48b4c425fcaa/sandbox/linux-sandbox/2798/execroot/CompilerGym && \
  exec env - \
    LD_LIBRARY_PATH=/opt/hostedtoolcache/Python/3.9.5/x64/lib \
    PATH=/home/runner/.cache/bazelisk/downloads/bazelbuild/bazel-4.0.0-linux-x86_64/bin:/opt/hostedtoolcache/Python/3.9.5/x64/bin:/opt/hostedtoolcache/Python/3.9.5/x64:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/home/runner/.local/bin:/opt/pipx_bin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin \
    *** \
  /usr/bin/clang @bazel-out/k8-fastbuild/bin/examples/RandomSearch-2.params)
Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox
bazel-out/k8-fastbuild/bin/examples/_objs/RandomSearch/RandomSearch.pic.o:RandomSearch.cc:function compiler_gym::runtime::CompilerGymService<compiler_gym::llvm_service::LlvmSession>::GetSpaces(grpc::ServerContext*, compiler_gym::GetSpacesRequest const*, compiler_gym::GetSpacesReply*): error: undefined reference to 'google::protobuf::RepeatedPtrField<compiler_gym::ActionSpace>::~RepeatedPtrField()'
bazel-out/k8-fastbuild/bin/examples/_objs/RandomSearch/RandomSearch.pic.o:RandomSearch.cc:function compiler_gym::runtime::CompilerGymService<compiler_gym::llvm_service::LlvmSession>::GetSpaces(grpc::ServerContext*, compiler_gym::GetSpacesRequest const*, compiler_gym::GetSpacesReply*): error: undefined reference to 'google::protobuf::RepeatedPtrField<compiler_gym::ObservationSpace>::~RepeatedPtrField()'
bazel-out/k8-fastbuild/bin/examples/_objs/RandomSearch/RandomSearch.pic.o:RandomSearch.cc:function compiler_gym::runtime::CompilerGymService<compiler_gym::llvm_service::LlvmSession>::GetSpaces(grpc::ServerContext*, compiler_gym::GetSpacesRequest const*, compiler_gym::GetSpacesReply*): error: undefined reference to 'google::protobuf::RepeatedPtrField<compiler_gym::ActionSpace>::~RepeatedPtrField()'
bazel-out/k8-fastbuild/bin/examples/_objs/RandomSearch/RandomSearch.pic.o:RandomSearch.cc:function compiler_gym::runtime::CompilerGymService<compiler_gym::llvm_service::LlvmSession>::GetSpaces(grpc::ServerContext*, compiler_gym::GetSpacesRequest const*, compiler_gym::GetSpacesReply*): error: undefined reference to 'google::protobuf::RepeatedPtrField<compiler_gym::ObservationSpace>::~RepeatedPtrField()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Issue facebookresearch#254.

Supporting the Fork() operator is optional for CompilationSessions, so provide a fallback implementation that creates a new environment and replays the action sequence by hand.

Encourage re-use of code within rules, and allow the test target to be overriden from the command line.

process.poll() may return 0.

Use SIGTERM rather than SIGKILL to terminate backend services, and then check that the process ended with returncode zero.

This adds a SIGTERM handler which enables the gRPC server to be shutdown gracefully. This enables an address sanitized build to run the end-of-process leak check.

ChrisCummins · 2021-05-27T14:26:16Z

Fixed the destructor linker error by rewriting the code using for loops rather than direct vector assignment. There's still a few bits to fix up in the CI configs then I'll merge.

codecov-commenter · 2021-05-27T14:40:35Z

Codecov Report

Merging #277 (f858b34) into development (2ce4af9) will decrease coverage by 0.22%.
The diff coverage is 52.94%.

❗ Current head f858b34 differs from pull request most recent head 4187b9d. Consider uploading reports for the commit 4187b9d to get more accurate results

@@               Coverage Diff               @@
##           development     #277      +/-   ##
===============================================
- Coverage        82.07%   81.84%   -0.23%     
===============================================
  Files               87       87              
  Lines             4731     4765      +34     
===============================================
+ Hits              3883     3900      +17     
- Misses             848      865      +17

Impacted Files	Coverage Δ
...ice/runtime/create_and_run_compiler_gym_service.py	`42.37% <28.57%> (-3.97%)`	⬇️
compiler_gym/service/connection.py	`74.02% <63.63%> (+0.02%)`	⬆️
compiler_gym/envs/compiler_env.py	`85.90% <73.68%> (-0.52%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce4af9...4187b9d. Read the comment docs.

Try and keep all jobs in a workflow the same. E.g. don't bundle code coverage along with unit tests, etc.

ChrisCummins · 2021-05-27T16:52:06Z

All test signals green. Merging!

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 17, 2021

ChrisCummins force-pushed the runtime-port branch from fbd2af0 to d337475 Compare May 17, 2021 22:08

hughleat approved these changes May 18, 2021

View reviewed changes

ChrisCummins force-pushed the runtime-port branch from 9fbb74e to f8a1085 Compare May 18, 2021 10:20

ChrisCummins force-pushed the runtime-port branch from 90e5b7a to abe23a4 Compare May 20, 2021 14:53

ChrisCummins added 23 commits May 27, 2021 14:17

[rpc] Enable arena codegen.

7895f33

Bump bazel gRPC dependency to 1.37.1.

c81e3c1

[examples] Port the example services to use the new service runtime.

a0bb5a8

Issue facebookresearch#254.

[llvm] Port LLVM service to the new CompilationSession interface.

f7346d9

Issue facebookresearch#254.

[env] Add a fallback fork() implementation.

964cdf4

Supporting the Fork() operator is optional for CompilationSessions, so provide a fallback implementation that creates a new environment and replays the action sequence by hand.

Run pre-commit install as part of make init.

96ad041

[ci] Remove unnecessary env variables from build steps.

d3c03be

[makefile] Add a BUILD_TARGET variable.

94dcc6b

[makefile] Make make install-test rules more flexible.

c89b6a4

Encourage re-use of code within rules, and allow the test target to be overriden from the command line.

[tests] Fix fork() test.

fb6c2f1

process.poll() may return 0.

[tests] Update llvm-stress fuzzer to new dataset API.

0afa353

[rpc] Raise ServiceError on service does not close gracefully.

db53297

Use SIGTERM rather than SIGKILL to terminate backend services, and then check that the process ended with returncode zero.

[service] Add graceful shutdown handling to gym services.

dab6533

This adds a SIGTERM handler which enables the gRPC server to be shutdown gracefully. This enables an address sanitized build to run the end-of-process leak check.

[ci] Add an asan test for LLVM service.

7a92fa5

[rpc] Make session leak detection consistent between C++/Python.

6d60103

[tests] Update the connection tests.

295e3d9

[tests] Update LLVM env tests.

69de1c6

[rpc] Raise a single exception on sessions leak check failure.

24221ef

[env] Log a failed attempt to close a compiler session.

4679476

[ci] Tidy up workflow definitions.

bdeb6fa

[runtime] Set Python runtime logging verbosity from debug level.

7e2bc96

[runtime] Fix Python shutdown signal handler.

d9e74c3

[tests] Treat warnings as errors in make install-test.

136bec9

ChrisCummins and others added 10 commits May 27, 2021 14:17

Bump ProGraML dependency.

4ad84aa

[ci] Keep the $CC and $CXX variables set for install-test.

3a5aad8

Add zlib to list of install deps.

c33b164

Rollback grpc dependency to 1.36.0.

3a289be

Add missing whitespace in command.

8a0d420

[packaging] Add missing dependencies to Dockerfile.

dc8ec76

[packaging] Update curl package version for docker.

b2ac824

[packaging] Add missing test dependencies to Dockerfile.

b6877ec

[service] Register SIGTERM handlers immediately.

efeb0c9

[packaging] Add a container_init script.

fb93690

ChrisCummins force-pushed the runtime-port branch from 30f373f to 3cdb0e5 Compare May 27, 2021 13:18

ChrisCummins and others added 2 commits May 27, 2021 14:33

[rpc] Workaround service link-time error.

e54df27

[tests] Relax strictness of error message checks.

c2d511f

ChrisCummins force-pushed the runtime-port branch from 3cdb0e5 to c2d511f Compare May 27, 2021 13:33

[Makefile] Fix install-test working directory path for coverage.

f858b34

ChrisCummins force-pushed the runtime-port branch 2 times, most recently from 39916c6 to 4187b9d Compare May 27, 2021 14:18

ChrisCummins added 4 commits May 27, 2021 16:24

[ci] Split test jobs into multiple workflows.

54e5ad0

Try and keep all jobs in a workflow the same. E.g. don't bundle code coverage along with unit tests, etc.

[service] Disable coverage in subprocess script.

c5faa40

[tests] Add a verbose logging test for example environments.

5ab1b51

[tests] Move random actions test into fuzz directory.

f4fe600

ChrisCummins force-pushed the runtime-port branch from 4187b9d to f4fe600 Compare May 27, 2021 15:27

ChrisCummins merged commit 9ab1b04 into facebookresearch:development May 27, 2021

ChrisCummins deleted the runtime-port branch May 27, 2021 16:52

This was referenced Jun 3, 2021

Release v0.1.9 #288

Merged

Release v0.1.9 #289

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port the compiler gym service backends to the new API #277

Port the compiler gym service backends to the new API #277

ChrisCummins commented May 17, 2021

hughleat left a comment

hughleat May 18, 2021

ChrisCummins May 18, 2021

hughleat May 18, 2021

ChrisCummins May 18, 2021

ChrisCummins commented May 18, 2021 •

edited

Loading

ChrisCummins commented May 20, 2021

ChrisCummins commented May 27, 2021

codecov-commenter commented May 27, 2021

ChrisCummins commented May 27, 2021

Port the compiler gym service backends to the new API #277

Port the compiler gym service backends to the new API #277

Conversation

ChrisCummins commented May 17, 2021

hughleat left a comment

Choose a reason for hiding this comment

hughleat May 18, 2021

Choose a reason for hiding this comment

ChrisCummins May 18, 2021

Choose a reason for hiding this comment

hughleat May 18, 2021

Choose a reason for hiding this comment

ChrisCummins May 18, 2021

Choose a reason for hiding this comment

ChrisCummins commented May 18, 2021 • edited Loading

ChrisCummins commented May 20, 2021

ChrisCummins commented May 27, 2021

codecov-commenter commented May 27, 2021

Codecov Report

ChrisCummins commented May 27, 2021

ChrisCummins commented May 18, 2021 •

edited

Loading