Remove SeekableInputStream.h include from FormatData.h

[majetideepak]

SeekableInputStream.h is causing the protobuf dependency to leak into Velox clients.
Move the PositionProvider class to its own file.

In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/connectors/hive/iceberg/IcebergSplitReader.cpp:17:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/connectors/hive/iceberg/IcebergSplitReader.h:21:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/connectors/hive/iceberg/PositionalDeleteFileReader.h:26:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/Reader.h:27:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/SelectiveColumnReader.h:22:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/FormatData.h:21:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/SeekableInputStream.h:23:
/Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/wrap/zero-copy-stream-wrapper.h:31:10: fatal error: 'google/protobuf/io/zero_copy_stream.h' file not found
#include <google/protobuf/io/zero_copy_stream.h>

See prestodb/presto#23528

[netlify]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	1062c20
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/66cdfbacc3c69c000814df79

[czentgr]

Thanks for the quick fix.

[majetideepak]

@kgpai can you please take a look? Thanks!

[facebook-github-bot]

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kgpai merged this pull request in 7e4d626.

[conbench-facebook]

Conbench analyzed the 1 benchmark run on commit 7e4d6263.

There was 1 benchmark result indicating a performance regression:

• Commit Run on GitHub-runner-8-core at 2024-09-10 18:13:33Z
  • compareSimilarRow (C++) with source=cpp-micro, suite=velox_benchmark_basic_vector_compare

The full Conbench report has more details.