-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SparkSql fuzzer proto files generation. #10810
Conversation
✅ Deploy Preview for meta-velox canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. The extra copy could indeed be removed.
cc: @kgpai @assignUser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
) Summary: A follow-up improvement for facebookincubator#10357 to avoid the following issue by reading proto files directly from Spark source code, instead of copying files. ```sh Untracked files: (use "git add <file>..." to include in what will be committed) velox/functions/sparksql/fuzzer/proto/ ``` Pull Request resolved: facebookincubator#10810 Reviewed By: bikramSingh91 Differential Revision: D61867378 Pulled By: kgpai fbshipit-source-id: e8df2cf8c590f10415a0e84bce1b640fcce159da
) Summary: A follow-up improvement for facebookincubator#10357 to avoid the following issue by reading proto files directly from Spark source code, instead of copying files. ```sh Untracked files: (use "git add <file>..." to include in what will be committed) velox/functions/sparksql/fuzzer/proto/ ``` Pull Request resolved: facebookincubator#10810 Reviewed By: bikramSingh91 Differential Revision: D61867378 Pulled By: kgpai fbshipit-source-id: e8df2cf8c590f10415a0e84bce1b640fcce159da
A follow-up improvement for #10357 to avoid the following issue by reading proto files directly from Spark source code, instead of copying files.