Args: Add path arg type to fix working directory handling
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: * Add new argument type `path:` * This makes relative paths work correctly when passed as arguments * Previously, if you passed `--arg myarg=foo/bar` the behavior was busted because the TTP will change its working directory to the parent directory of the TTP's YAML file, and `foo/bar` won't exist there, even if it existed in the directory from which you invoked ttpforge :( * Updated all examples to use the new arguments Reviewed By: d0n601 Differential Revision: D51475492
|
This pull request was exported from Phabricator. Differential Revision: D51475492 |
|
This pull request has been merged in 246f1a2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
path:--arg myarg=foo/barthe behavior was busted because the TTP will change its working directory to the parent directory of the TTP's YAML file, andfoo/barwon't exist there, even if it existed in the directory from which you invoked ttpforge :(Reviewed By: d0n601
Differential Revision: D51475492