-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[interfaces] add pareto interfaces #1052
Open
alxlyj
wants to merge
6
commits into
robynpy_release
Choose a base branch
from
review_ready_pareto
base: robynpy_release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+740
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 13, 2024
sumane81
reviewed
Sep 13, 2024
python/src/robyn/modeling/pareto/immediate_carryover_calculator.py
Outdated
Show resolved
Hide resolved
sumane81
reviewed
Sep 13, 2024
python/src/robyn/modeling/pareto/immediate_carryover_calculator.py
Outdated
Show resolved
Hide resolved
sumane81
reviewed
Sep 13, 2024
python/src/robyn/modeling/pareto/immediate_carryover_calculator.py
Outdated
Show resolved
Hide resolved
sumane81
reviewed
Sep 13, 2024
sumane81
reviewed
Sep 13, 2024
sumane81
reviewed
Sep 13, 2024
sumane81
reviewed
Sep 13, 2024
sumane81
reviewed
Sep 13, 2024
sumane81
reviewed
Sep 13, 2024
python/src/robyn/modeling/pareto/immediate_carryover_calculator.py
Outdated
Show resolved
Hide resolved
sumane81
reviewed
Sep 13, 2024
python/src/robyn/modeling/pareto/immediate_carryover_calculator.py
Outdated
Show resolved
Hide resolved
sumane81
reviewed
Sep 13, 2024
sumane81
reviewed
Sep 13, 2024
sumane81
reviewed
Sep 13, 2024
sumane81
reviewed
Sep 13, 2024
sumane81
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits; but strongly suggest addressing them.
alxlyj
force-pushed
the
review_ready_pareto
branch
from
September 17, 2024 20:19
73681fb
to
99bec6b
Compare
pareto_optimizer.py
pareto_utils.py
response_curve.py
immediate_carryover.py
|
Updated diagrams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Robyn
Depends on #1050
Summary: We are including the interfaces (methods and data classes) for the pareto subcomponent in Python. This interface is inferred from pareto.R.
What is new:
Test Plan
Class diagram
Parity: