This repository has been archived by the owner on Aug 22, 2024. It is now read-only.
Adapt to nightly 2021-02-12 #754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
added 6 commits
February 12, 2021 15:13
hermanventer
force-pushed
the
new_nightly
branch
from
f6f1509
to
2c3813f
Compare
hermanventer
force-pushed
the
new_nightly
branch
from
2c3813f
to
5712386
Compare
hermanventer
commented
Feb 12, 2021
| @@ -161,8 +163,8 @@ impl<'analysis, 'compilation, 'tcx, E> BodyVisitor<'analysis, 'compilation, 'tcx | |||
| function_constant_args: &[(Rc<Path>, Rc<AbstractValue>)], | |||
| parameter_types: &[Ty<'tcx>], | |||
| ) -> Summary { | |||
| if cfg!(DEBUG) { | |||
| let mut stdout = std::io::stdout(); | |||
| if !cfg!(DEBUG) { | |||
There was a problem hiding this comment.
If you remove the prefixed negation, all tests should pass. If you keep the negation and fix the write_mir_pretty issue, all tests should pass.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is branch that illustrates a problem with write_mir_pretty in recent nightly builds. See rust-lang/rust#81200.
To reproduce the issue, clone MIRAI from github. Modify rust-toolchain to match the version you are using to test the fix. Then run cargo test.
Without a fix, you should see a bunch of failures such as:
thread 'rustc' panicked at 'DefId::expect_local:
DefId(5:3241 ~ alloc[4acc]::collections::vec_deque::{impl#4}::new)isn't local', /rustc/0fc6756b42e0556cc2e18079f5fc6b4d58f4e81a/compiler/rustc_span/src/def_id.rs:175:43n