Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

React Native debugger doesn't work with React Native v0.21.0-rc #376

Closed
Nikamura opened this issue Feb 26, 2016 · 13 comments
Closed

React Native debugger doesn't work with React Native v0.21.0-rc #376

Nikamura opened this issue Feb 26, 2016 · 13 comments

Comments

@Nikamura
Copy link

Issue and Steps to Reproduce

  • Create project using RN v0.21.0-rc
  • Start packager
  • Start react native debugger in atom
  • Enable "chrome debugging" in the application

Expected Behavior

  • Nuclide attaches automatically, and application loads normally so you can continue debugging.

Actual Behavior

  • Nuclide attaches automatically, but application is stuck at loading from localhost:8081...
    image

Versions

  • Atom: 1.5.3
  • Nuclide: 0.119.0
  • Client OS: OS X 10.10

Additional Details

/Users/*/.atom/packages (1)
└── nuclide@0.119.0

I know that 0.21.0-rc changed some stuff in the Chrome debugging facebook/react-native@64d56f3 so don't really know if this is atom bug or React Native

@matthewwithanm
Copy link
Contributor

Hi @Nikamura! Two quick questions. Have you used the debugger successfully with a previous version of RN? Also, what version of node do you have installed?

@Nikamura
Copy link
Author

@matthewwithanm Just tested with the latest stable version and it didn't work also. So no.
Node version is 5.7.0. Just saw the video from the conference where you guys displayed all the cool tricks Atom can do, so wanted to give it a try over ST3.

@matthewwithanm
Copy link
Contributor

Ah, I think I see. Sometimes the debugger gets stuck for some reason. Can you hit the Pause button (F8) and see if it resumes?

@Nikamura
Copy link
Author

Tried on two different RN apps on two different simulators, got two different errors after clicking fn+f8 (osx)

screen shot 2016-02-27 at 01 23 58

screen shot 2016-02-27 at 01 15 55

@matthewwithanm
Copy link
Contributor

Okay, those are RN issues 😢

I have commits in to fix it (facebook/react-native@bb3d8d5 and facebook/react-native@ecf6981) that I'm hoping to get into 0.21.

@Nikamura
Copy link
Author

Okay cheers, I will cherry pick them until then. Have a good weekend:)

@matthewwithanm
Copy link
Contributor

You too! Thanks for helping me diagnose!

@Nikamura
Copy link
Author

It works, but I don't know if the behaviour is intended https://gfycat.com/UnconsciousImaginativeEel it always come up paused or something cause after each reload I have to press FN+F8, should I be using hot reloading to be able to use the debugging?

@matthewwithanm
Copy link
Contributor

The paused thing is a bug 😢. I'll try to figure it out ASAP.

@Nikamura
Copy link
Author

Nikamura commented Mar 9, 2016

@matthewwithanm the bug where debugger starts paused (tested with nuclide master) is still present. Do you need any help debugging it?

@matthewwithanm
Copy link
Contributor

Sorry, I've been working on an overhaul of the debugger stuff that's taken longer than anticipated. I'll put in a quick fix for this today.

@Nikamura
Copy link
Author

Nikamura commented Mar 9, 2016

Okay, thanks. Waiting for it.

@matthewwithanm matthewwithanm self-assigned this Mar 9, 2016
ghost pushed a commit that referenced this issue Mar 9, 2016
Summary:This is a band-aid for #376 while I work on the RN debugger overhaul.

public

Reviewed By: bottledwalter

Differential Revision: D3030102

fb-gh-sync-id: 32abfca21cc1f46398cbf4c9cb8d9aec6157154c
shipit-source-id: 32abfca21cc1f46398cbf4c9cb8d9aec6157154c
@matthewwithanm
Copy link
Contributor

Hey all! I've pushed a bunch of updates. Here's the current story (as of bb3311c):

  1. You don't have to unpause between reloads (yay!)
  2. The debugger isn't paused when you attach it if you're running node 4 (yay!)
  3. …but it is if you're running v5 (boo!)

I've opened a new issue (#402) for the remaining bug. Thanks for bearing with me!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants