[0.21] Commits to cherry-pick into 0.21-stable

[bestander]

• 78a9125 Update ScrollResponder.js to use new scrollTo API. This fixes a warning in the current release version.
• ecf6981 Only freeze valid attributes in mountComponent
• Disable HMR menu option on Android, not ready for prime time just yet: f514409

[bestander]

@mkonicek, should we make more changes to cli upgrade command?
It seems that Gradle still downloads react-native 0.20.1 from Maven.
We need to link gradle to the .jar in node_modules.

[janicduplessis]

78a9125 Update ScrollResponder.js to use new scrollTo API. This fixes a warning in the current release version.

[mkonicek]

👍 Thanks @janicduplessis!

@bestander The artifacts should be loaded from node_modules, here's the commit which implemented that: 702f999.

To test this I just did the following:

Created a new app using 0.21.0-rc. react-native init still uses 0.20.0 because that's marked as latest in npm.

In package.json, I changed the RN dependency to 0.21.0-rc, rm -rf node_modules, npm install.

Ran:

$ cd android
$ ./gradlew app:dependencies
...    
com.facebook.react:react-native:+ -> 0.21.0
...

Just to double check, I did rm -rf ~/.gradle/cache and ran react-native run-android:

Saw the POM file is still downloaded (this is indeed surprising, good catch!):

Download https://jcenter.bintray.com/com/facebook/react/react-native/0.20.1/react-native-0.20.1.pom
...
Download https://jcenter.bintray.com/com/facebook/fresco/imagepipeline-okhttp/0.8.1/imagepipeline-okhttp-0.8.1.aar

But the .aar file wasn't downloaded and the app builds.

Based on the above I'm pretty sure the app uses 0.21 artifacts from node_modules.

[jsierles]

If #5084 is ready in the next day or so, it would be great to get it in, so Relay can be used out of the box with React Native!

[lostintangent]

It would be awesome if #6119 could be considered as well, since this has been a source of confusion for a lot of users.

[Kureev]

Also looking forward for #5084

[mkonicek]

Hey guys, I'm looking forward to #5084 landing as well. David Aurelio is working hard to merge it into the fb codebase. Our internal setup makes it not trivial to merge unfortunately.

@lostintangent The cherry-picks are intended for small and completely safe bug-fixes. #6119 looks great but by looking at the code I can't tell with 100% confidence it won't break anything for anyone so prefer to release it in 0.22.0-rc next week and let people test it for 2 weeks before shipping it in 0.22.

[matthewwithanm]

Could you please grab ecf6981? It's kind of a follow-up to bb3d8d5 (which I think is already in).

[mkonicek]

@spicyj Should we cherry-pick ecf6981 into the release? bb3d8d5 is in, not sure if it makes sense without the followup commit?

[sophiebits]

The latter stands alone as an improvement, but the former is a bug fix that we could include. I am fine either way.

[lostintangent]

@mkonicek Makes sense, I just thought I would ask :) Thanks!

[matthewwithanm]

ecf6981 is needed to avoid an error in Nuclide debugging so I would really appreciate it!