Enable -Wextra in C++ builds #1294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D45772846 |
NickGerleman
force-pushed
the
export-D45772846
branch
from
f7679bd
to
68c0525
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45772846 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
May 11, 2023
Summary: Pull Request resolved: facebook#1294 X-link: facebook/react-native#37383 Add -Wextra to the build, and fixup some more instances of -Wunused-parameter that it sufaces which were not automatically fixable. Reviewed By: javache Differential Revision: D45772846 fbshipit-source-id: de57ea54b06ab43184b4cebaa6c8d61f7be12d77
NickGerleman
force-pushed
the
export-D45772846
branch
from
68c0525
to
6ee19ae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45772846 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
May 11, 2023
Summary: Pull Request resolved: facebook#1294 X-link: facebook/react-native#37383 Add -Wextra to the build, and fixup some more instances of -Wunused-parameter that it sufaces which were not automatically fixable. Reviewed By: javache Differential Revision: D45772846 fbshipit-source-id: 631502076aeeec8fbdf3895960d5ab9c6c82aeae
NickGerleman
force-pushed
the
export-D45772846
branch
from
6ee19ae
to
d112ea9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45772846 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
May 11, 2023
Summary: Pull Request resolved: facebook#1294 X-link: facebook/react-native#37383 Add -Wextra to the build, and fixup some more instances of -Wunused-parameter that it sufaces which were not automatically fixable. Reviewed By: javache Differential Revision: D45772846 fbshipit-source-id: bdf151616c4ae8a47947670d1429e0d4ba9a2232
NickGerleman
force-pushed
the
export-D45772846
branch
from
d112ea9
to
5a19567
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45772846 |
Summary: Gets the project clean of `-Wunused-parameter`, part of `-Wextra`. Enforced as part of the build now. Differential Revision: https://internalfb.com/D45772554 fbshipit-source-id: e7ec6f4047b3994c3615a4557ffc4f3677f9c1e6
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1294 Pull Request resolved: facebook#37383 Add -Wextra to the build, and fixup some more instances of -Wunused-parameter that it sufaces which were not automatically fixable. Reviewed By: javache Differential Revision: D45772846 fbshipit-source-id: 59e7993efe0731b4dc2d5683d1670e934617c17d
Summary: Pull Request resolved: facebook#1294 X-link: facebook/react-native#37383 Add -Wextra to the build, and fixup some more instances of -Wunused-parameter that it sufaces which were not automatically fixable. Reviewed By: javache Differential Revision: D45772846 fbshipit-source-id: 680498f66f2104c29a71366bf30dba8895d9baf4
NickGerleman
force-pushed
the
export-D45772846
branch
from
5a19567
to
8bbd7c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45772846 |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1294 Pull Request resolved: #37383 Add -Wextra to the build, and fixup some more instances of -Wunused-parameter that it sufaces which were not automatically fixable. Reviewed By: javache Differential Revision: D45772846 fbshipit-source-id: 29bf71006f63161521fe5869c3a7d8bf7aae9c81
|
This pull request has been merged in e53d1ee. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1294 X-link: facebook/react-native#37383 Add -Wextra to the build, and fixup some more instances of -Wunused-parameter that it sufaces which were not automatically fixable. Reviewed By: javache Differential Revision: D45772846 fbshipit-source-id: 29bf71006f63161521fe5869c3a7d8bf7aae9c81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add -Wextra to the build, and fixup some more instances of -Wunused-parameter that it sufaces which were not automatically fixable.
Differential Revision: D45772846