Undeprecate Config setting APIs (#36990) #1251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebook/react-native#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Differential Revision: D45133646 fbshipit-source-id: eb148802732e76b5e2e7bb85e3a3e0da229df1e4
|
This pull request was exported from Phabricator. Differential Revision: D45133646 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1251 Pull Request resolved: facebook#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Differential Revision: D45133646 fbshipit-source-id: af79d8dffe35468de945eb15ebe7de7bdcd02fa0
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1251 Pull Request resolved: facebook#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Differential Revision: https://internalfb.com/D45133646 fbshipit-source-id: 79f06c221c0f925e0a1a02ccd7226f63ebf651b2
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1251 Pull Request resolved: facebook#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Differential Revision: https://internalfb.com/D45133646 fbshipit-source-id: bc8dc92922c065ae7b8832ced33e740bd80bfa57
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1251 Pull Request resolved: facebook#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Differential Revision: https://internalfb.com/D45133646 fbshipit-source-id: 5af481dfc1da0da564088a1c2b3e9a36bda664d7
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1251 Pull Request resolved: facebook#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Differential Revision: https://internalfb.com/D45133646 fbshipit-source-id: 0cd506f55fb8ac4c358bf6935fcd6cf3f604764b
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1251 Pull Request resolved: facebook#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Differential Revision: https://internalfb.com/D45133646 fbshipit-source-id: b15361e5c2189a0740958bab3f006cffcffba14d
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1251 Pull Request resolved: facebook#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Differential Revision: https://internalfb.com/D45133646 fbshipit-source-id: 2f53860e78e48b96bab74fda88065daf7c60216f
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1251 Pull Request resolved: facebook#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Differential Revision: https://internalfb.com/D45133646 fbshipit-source-id: 1aa043075ae25d772e105fa3366063c433adeab1
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1251 Pull Request resolved: facebook#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Differential Revision: https://internalfb.com/D45133646 fbshipit-source-id: c7781122bf9c6c0b58fb00cb335f14cd56a28f35
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1251 Pull Request resolved: facebook#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133646 fbshipit-source-id: fb181e3f6fd632d77e9ff68a5ed889e271167069
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1251 X-link: facebook/react-native#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133646 fbshipit-source-id: 2bb15c4825717793529cdad8542447d11e723e35
|
This pull request has been merged in 19e15a4. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1251 Pull Request resolved: #36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133646 fbshipit-source-id: 2bb15c4825717793529cdad8542447d11e723e35
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: X-link: facebook/yoga#1251 Pull Request resolved: facebook#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133646 fbshipit-source-id: 2bb15c4825717793529cdad8542447d11e723e35
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: X-link: facebook/yoga#1251 Pull Request resolved: facebook#36990 YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node. While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this. This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133646 fbshipit-source-id: 2bb15c4825717793529cdad8542447d11e723e35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#36990
YGNode::setConfig was deprecated as part of D15416474 in an apparent goal to remove config pointers per-Node.
While I don't know the history of the motivation here, these config pointers were never removed, and we will be doubling down on per-node configs for StrictLayout, so we will want to undeprecate this.
This also exposes functions to the public C ABI, but I didn't spend the effort to create language projections for it.
Differential Revision: D45133646