Fix measure inner dimensions #1114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rshest
reviewed
Oct 7, 2022
yoga/Yoga.cpp
Outdated
Comment on lines
2956
to
2958
| collectedFlexItemsValues.totalFlexGrowFactors) || | ||
| collectedFlexItemsValues.totalFlexGrowFactors == 0) || | ||
| (YGFloatIsUndefined(node->resolveFlexGrow()) && | ||
| (YGFloatIsUndefined(node->resolveFlexGrow()) || |
There was a problem hiding this comment.
Guess those extra parentheses are redundant, now that it's a list of OR clauses... granted, the expression is quite hard to unpack visually, and extra parentheses don't help here, quite an opposite
There was a problem hiding this comment.
I actually believe that the original intent there may have been to have it like this instead:
if (!node->getConfig()->useLegacyStretchBehaviour &&
((!YGFloatIsUndefined(
collectedFlexItemsValues.totalFlexGrowFactors) &&
collectedFlexItemsValues.totalFlexGrowFactors == 0) ||
(!YGFloatIsUndefined(node->resolveFlexGrow()) &&
node->resolveFlexGrow() == 0))) {There was a problem hiding this comment.
Yeah, you're right. I had update this code.
rshest
requested changes
Oct 7, 2022
kinarobin
force-pushed
the
fix-flex-inner-main-dimension-measure
branch
from
6be2fbf
to
9f85924
Compare
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Oct 11, 2022
Summary: `YGFloatIsUndefined(collectedFlexItemsValues.totalFlexGrowFactors) && collectedFlexItemsValues.totalFlexGrowFactors == 0` is not reachable. X-link: facebook/yoga#1114 Reviewed By: NickGerleman Differential Revision: D40203817 Pulled By: NickGerleman fbshipit-source-id: 46a8c19dc0e097f4c28e7f48135f0382a557764a
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 11, 2022
Summary: `YGFloatIsUndefined(collectedFlexItemsValues.totalFlexGrowFactors) && collectedFlexItemsValues.totalFlexGrowFactors == 0` is not reachable. X-link: facebook/yoga#1114 Reviewed By: NickGerleman Differential Revision: D40203817 Pulled By: NickGerleman fbshipit-source-id: 46a8c19dc0e097f4c28e7f48135f0382a557764a
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: `YGFloatIsUndefined(collectedFlexItemsValues.totalFlexGrowFactors) && collectedFlexItemsValues.totalFlexGrowFactors == 0` is not reachable. X-link: facebook/yoga#1114 Reviewed By: NickGerleman Differential Revision: D40203817 Pulled By: NickGerleman fbshipit-source-id: 46a8c19dc0e097f4c28e7f48135f0382a557764a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YGFloatIsUndefined(collectedFlexItemsValues.totalFlexGrowFactors) && collectedFlexItemsValues.totalFlexGrowFactors == 0is not reachable.