Move ApplyWALToManifest before memtable insertion #12869
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context/Summary:
ApplyWALToManifest currently happens after memtable write, not immediately after WAL write/sync. This causes some stress test failure where the key is in memtable so it's expected to exist while we rollback the ExpectedState due to write failure.
Test:
iterator has key 0000000000000207000000000000012B0000000000000013, but expected state does not.
before this PR and passes after