Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid division by zero #12850

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

amir
Copy link

@amir amir commented Jul 9, 2024

In some scenario the advisor fails with the following stack trace:

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/Users/amir/Sources/rocksdb/tools/advisor/advisor/rule_parser_example.py", line 98, in <module>
    main(args)
  File "/Users/amir/Sources/rocksdb/tools/advisor/advisor/rule_parser_example.py", line 42, in main
    triggered_rules = rule_spec_parser.get_triggered_rules(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/amir/Sources/rocksdb/tools/advisor/advisor/rule_parser.py", line 479, in get_triggered_rules
    self.trigger_conditions(data_sources)
  File "/Users/amir/Sources/rocksdb/tools/advisor/advisor/rule_parser.py", line 496, in trigger_conditions
    source.check_and_trigger_conditions(cond_subset)
  File "/Users/amir/Sources/rocksdb/tools/advisor/advisor/db_timeseries_parser.py", line 148, in check_and_trigger_conditions
    result = self.fetch_burst_epochs(
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/amir/Sources/rocksdb/tools/advisor/advisor/db_timeseries_parser.py", line 88, in fetch_burst_epochs
    diff = diff * 100 / first_val
           ~~~~~~~~~~~^~~~~~~~~~~
ZeroDivisionError: float division by zero

@facebook-github-bot
Copy link
Contributor

Hi @amir!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants