Fix MultiGet dropping memtable kv checksum corruption #12842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
anand1976
approved these changes
Aug 7, 2024
db/memtable.cc
Outdated
| @@ -1310,7 +1314,7 @@ bool MemTable::Get(const LookupKey& key, std::string* value, | |||
|
|
|||
| // No change to value, since we have not yet found a Put/Delete | |||
| // Propagate corruption error | |||
| if (!found_final_value && merge_in_progress && !s->IsCorruption()) { | |||
| if (!found_final_value && merge_in_progress && s->ok()) { | |||
There was a problem hiding this comment.
Should we assert(s,ok())? If non-ok status, then found_final_value should always be true right?
There was a problem hiding this comment.
It can also be merge in process, added assert on this.
cbi42
force-pushed
the
multiget-checksum
branch
from
720d30c
to
9f050b9
Compare
|
@cbi42 has updated the pull request. You must reimport the pull request before landing. |
Added, thanks for the review. |
|
@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corruption status returned by
GetFromTable()could be overwritten here:rocksdb/db/version_set.cc
Line 2614 in b6c3495
This PR fixes this issue by setting
*(s->found_final_value) = true;in SaveValue. Also makes the handling of the return value ofGetFromTable()more robust and added asserts in a couple places.Test plan: Updated an existing unit test to cover MultiGet. It fails the assertion here before this PR:
rocksdb/db/version_set.cc
Line 2601 in b6c3495