Fix DB failed to resume after "no space left on device" error #12767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 11643
Summary:
The cause of this issue is that after recovery from "no space" problem, the seen_error flag in the WritableFileWriter was not reset.
IMO that the seen_error flag is used to prevent frequent write retries when an error is present.
A similar situation can be referenced in SyncWalImpl, where error_recovery_in_prog is true it also been reset.
Therefore, it is acceptable to reset it in ResumeImpl.
Considering that a successful resume is required and it needs to be done before 'OnErrorRecoveryCompleted', the changes are as follow.
Test Plan:
Added a test case 'NoSpaceOnWriteWalAndRecovery' in 'db_io_failure_test.cc' to test the "no space" error and recovery when writing WAL.
Modified 'db_test_util.h' to simulate the "no space" error when appending WAL.