Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: EnforceReadOpts #12765

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: EnforceReadOpts #12765

wants to merge 1 commit into from

Commits on Jun 12, 2024

  1. WIP: EnforceReadOpts 

    Summary: Follow-up from facebook#12757. New infrastructure to DEBUG builds to
catch certain ReadOptions being ignored in a context where they should
be in effect. This currently only applies to checking that no IO happens
when read_tier == kBlockCacheTier. The check is in effect for unit tests
and for stress/crash tests.

Specifically, an `EnforceReadOpts` object on the stack establishes a
thread-local context under which we assert no IOs are performed if the
provided ReadOptions said it should be forbidden.

Test Plan: Reports failure before production code fix in facebook#12757
    @pdillinger
    pdillinger committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    cc86a22 View commit details
    Browse the repository at this point in the history