Warning added if defaultProps were defined as an instance property

[abhaynikam]

• Added a warning if defaultProps were defined as an instance property
• Added related testcases for the changes done.
• Issue related to Warn in dev if shouldComponentUpdate is defined on PureComponent #9239

[abhaynikam]

@aweary : can you help me here? All the testcases are passing on my local but in circle ci, I am not sure why are they failing.

I was unable to run ./scripts/fiber/record-tests on my local.

[aweary]

@abhaynikam CI was failing because the recorded fiber tests weren't up-to-date. What kind of issues did you have running the record-tests script locally?

I went ahead and ran it for you and pushed it to your branch and CI is passing now 👍

[abhaynikam]

@aweary : While running the script ./scripts/fiber/record-tests

Error:

SyntaxError: Unexpected token {

On Line: https://github.com/facebook/react/blob/master/scripts/fiber/record-tests#L83

[aweary]

Thanks @abhaynikam, looks like we're using object destructuring which will cause this script to fail in earlier versions on Node. We'll either need to bump up the minimum supported version for development or update the script.

cc @gaearon which of those sounds preferable to you guys?

[abhaynikam]

Thanks for looking at it @aweary 👍

[gaearon]

I’m OK with bumping the minimal required version (independent of this PR).

[gaearon]

I would maybe add "It will be ignored." for clarity to the warning. Otherwise it's not clear what the behavior is. Wanna do a followup PR?

[abhaynikam]

@gaearon : I will update the warning message in the follow up PR.