Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make React 0.14 compatible with prop-types #9412

Merged
merged 1 commit into from
Apr 12, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Apr 12, 2017

Never thought I'd go back to 0.14 but here we are: reduxjs/react-redux#669.

It's reasonable for standalone prop-types package to support both 0.14 and 15 to ease the migration effort for library authors. So let's release React 0.14.9 that “understands” standalone prop-types by passing the secret.

(Also I hope this doesn't get me fired?)

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: I don't know 0.14 internals at all

But this change looks okay to me.

We're passing null for propFullName in few places where the value was previously undefined but looking at the source, that shouldn't make a difference.

@gaearon
Copy link
Collaborator Author

gaearon commented Apr 12, 2017

Verified it works by creating a new project using react-redux@4. No longer printing a ton of messages. Tests pass.

@gaearon gaearon merged commit e120862 into facebook:0.14-stable Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants