Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error codes update to release process #8749

Merged
merged 2 commits into from
Jan 12, 2017
Merged

Add error codes update to release process #8749

merged 2 commits into from
Jan 12, 2017

Conversation

zpao
Copy link
Member

@zpao zpao commented Jan 11, 2017

@gaearon
Copy link
Collaborator

gaearon commented Jan 11, 2017

Seems like we need to add these instructions: #7999 (comment).
Thus this should happen on dev branch, before we switched to stable.

Going to flag as needs revision, feel free to fix it, but I'll assign to myself to fix it up later.

@gaearon gaearon self-assigned this Jan 11, 2017
gaearon
gaearon requested changes Jan 11, 2017
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to do this on dev-branch (so this needs to happen earlier) and add a note about cherry-picking to master.

@gaearon gaearon merged commit 8835955 into facebook:master Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon requested changes

Assignees

@gaearon gaearon

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zpao @gaearon @facebook-github-bot