Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for movementX/Y in SyntheticMouseEvent #6727

Closed
wants to merge 1 commit into from

Conversation

aweary
Copy link
Contributor

@aweary aweary commented May 8, 2016

Resolves #6723

So there's still work that needs to be done here, but I wanted to open the PR so I could get feedback early on. I have a couple questions:

  1. To polyfill movementX/movementY you need the previous mouse event's screenX/screenY. I implemented a MouseMetrics here similar to ViewportMetrics. Is that the right approach?

1a. If MouseMetrics is an acceptable, is there a better place in the code path where I should register the new previousScreen{X,Y} values?

  1. I don't see any tests for SyntheticMouseEvents, am I just not seeing them or do they not exist? Where should I add tests for this?

Register screenX/Y after calculating values

Fix movementY variable name error

Linting fix

Return 0 in instanes where previous values are null
@ghost
Copy link

ghost commented May 8, 2016

@aweary updated the pull request.

@aweary
Copy link
Contributor Author

aweary commented Feb 13, 2017

I'll go ahead and close this out since it's never been reviewed and is out of date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants