Don't execute <script> tags w/ createElement mode #5146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var div = ownerDocument.createElement('div'); | ||
| div.innerHTML = | ||
| '<' + this._currentElement.type + | ||
| '></' + this._currentElement.type + '>'; |
There was a problem hiding this comment.
I guess we know here that this is "script" so we probably could just hard code that string. Otherwise, template strings?
There was a problem hiding this comment.
I did this for consistency with the other HTML generation (it could be capitalized differently). Also the token </script> would make browsers sad if someone tries to put the entire source of React within a script tag. I can do template strings except it doesn't fit on one line anyway…
Each script will execute at most once so we could also set `.textContent` to something like `;`, then add it to the document, then change the `.textContent`, but this seems like the simplest approach. See http://dev.w3.org/html5/spec-preview/the-script-element.html for details.
sophiebits
force-pushed
the
ce-scripts
branch
from
5b19e2f
to
db989bf
Compare
sophiebits
added a commit
that referenced
this pull request
Oct 12, 2015
Don't execute <script> tags w/ createElement mode
|
@spicyj updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each script will execute at most once so we could also set
.textContentto something like;, then add it to the document, then change the.textContent, but this seems like the simplest approach. See http://dev.w3.org/html5/spec-preview/the-script-element.html for details.