Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Normalize Stack Using Fake Evals #30401

Merged
merged 3 commits into from
Jul 22, 2024
Merged

[Flight] Normalize Stack Using Fake Evals #30401

merged 3 commits into from
Jul 22, 2024

Commits on Jul 22, 2024

  1. Build a normalized native stack trace using fake evals 

    We already do this for recreating serialized errors.

This does it for stacks both in the stacks of parent components,
JSX callsites and owners.
    @sebmarkbage
    sebmarkbage committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c062eb0 View commit details
    Browse the repository at this point in the history

  2. Rename task on ReactComponentInfo to debugTask 

    This represents the stack trace as a native console.createTask object in
the current execution environment. Not as part of the serialized protocol.
    @sebmarkbage
    sebmarkbage committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    8d29f53 View commit details
    Browse the repository at this point in the history

  3. Save native stack as a separate Error 

    This represents the stack in the current execution environment. As opposed
to the .stack property which represents the stack in the transport protocol.
    @sebmarkbage
    sebmarkbage committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    523ef76 View commit details
    Browse the repository at this point in the history