Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[circleci] Inline scrape_warning_messages #30388

Merged
merged 2 commits into from
Jul 18, 2024
Merged

[circleci] Inline scrape_warning_messages #30388

merged 2 commits into from
Jul 18, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 18, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

This job was only being used for process_artifacts_combined in circleci
but as it was a separate job would incur the cost and time of spinning
up a new CI worker. We can simply inline this into
process_artifacts_combined.

Test plan: Download
build.tgz
from circleci and observe that the test_utils directory is still
present.

@poteto
Update
51a2a24 
[ghstack-poisoned]
@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 7:58pm

This was referenced Jul 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
poteto added a commit that referenced this pull request Jul 18, 2024
@poteto
[circleci] Inline scrape_warning_messages
e7fad22 
This job was only being used for process_artifacts_combined in circleci
but as it was a separate job would incur the cost and time of spinning
up a new CI worker. We can simply inline this into
process_artifacts_combined.

ghstack-source-id: f7335ebf4832bec5392daa6d59ac34d1e4bac4da
Pull Request resolved: #30388
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Jul 18, 2024
@react-sizebot
Copy link

react-sizebot commented Jul 18, 2024 •
edited
Loading

Comparing: 512b09b...8ba5dc4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 499.44 kB 499.44 kB = 89.59 kB 89.59 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 504.26 kB 504.26 kB = 90.30 kB 90.31 kB
facebook-www/ReactDOM-prod.classic.js = 599.20 kB 599.20 kB = 105.79 kB 105.79 kB
facebook-www/ReactDOM-prod.modern.js = 573.37 kB 573.37 kB = 101.68 kB 101.68 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 5d15b46

@poteto
Update
5d15b46 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 18, 2024
@poteto
[circleci] Inline scrape_warning_messages
fc557be 
This job was only being used for process_artifacts_combined in circleci
but as it was a separate job would incur the cost and time of spinning
up a new CI worker. We can simply inline this into
process_artifacts_combined.

ghstack-source-id: 8748d8fb9cf01d8fffe7e7590729a44def265c79
Pull Request resolved: #30388
poteto added a commit that referenced this pull request Jul 18, 2024
@poteto
[circleci] Inline scrape_warning_messages
9e793f4 
This job was only being used for process_artifacts_combined in circleci
but as it was a separate job would incur the cost and time of spinning
up a new CI worker. We can simply inline this into
process_artifacts_combined.

ghstack-source-id: 8748d8fb9cf01d8fffe7e7590729a44def265c79
Pull Request resolved: #30388
poteto added a commit that referenced this pull request Jul 18, 2024
@poteto
[circleci] Inline scrape_warning_messages
bfba0e6 
This job was only being used for process_artifacts_combined in circleci
but as it was a separate job would incur the cost and time of spinning
up a new CI worker. We can simply inline this into
process_artifacts_combined.

ghstack-source-id: 8748d8fb9cf01d8fffe7e7590729a44def265c79
Pull Request resolved: #30388
poteto added a commit that referenced this pull request Jul 18, 2024
@poteto
[circleci] Inline scrape_warning_messages
106438c 
This job was only being used for process_artifacts_combined in circleci
but as it was a separate job would incur the cost and time of spinning
up a new CI worker. We can simply inline this into
process_artifacts_combined.

Test plan: Download
[build.tgz](https://app.circleci.com/pipelines/github/facebook/react/57183/workflows/3b22a99e-b8a5-4c80-9682-576f24581b00/jobs/956476/artifacts)
from circleci and observe that the __test_utils__ directory is still
present.

ghstack-source-id: 8748d8fb9cf01d8fffe7e7590729a44def265c79
Pull Request resolved: #30388
poteto added a commit that referenced this pull request Jul 18, 2024
@poteto
[circleci] Inline scrape_warning_messages
06feb90 
This job was only being used for process_artifacts_combined in circleci
but as it was a separate job would incur the cost and time of spinning
up a new CI worker. We can simply inline this into
process_artifacts_combined.

Test plan: Download
[build.tgz](https://app.circleci.com/pipelines/github/facebook/react/57183/workflows/3b22a99e-b8a5-4c80-9682-576f24581b00/jobs/956476/artifacts)
from circleci and observe that the __test_utils__ directory is still
present.

ghstack-source-id: 8748d8fb9cf01d8fffe7e7590729a44def265c79
Pull Request resolved: #30388
@poteto poteto requested a review from jackpope July 18, 2024 20:19
@poteto poteto merged commit 5d15b46 into gh/poteto/40/base Jul 18, 2024
187 checks passed
poteto added a commit that referenced this pull request Jul 18, 2024
@poteto
[circleci] Inline scrape_warning_messages
6fac743 
This job was only being used for process_artifacts_combined in circleci
but as it was a separate job would incur the cost and time of spinning
up a new CI worker. We can simply inline this into
process_artifacts_combined.

Test plan: Download
[build.tgz](https://app.circleci.com/pipelines/github/facebook/react/57183/workflows/3b22a99e-b8a5-4c80-9682-576f24581b00/jobs/956476/artifacts)
from circleci and observe that the __test_utils__ directory is still
present.

ghstack-source-id: 8748d8fb9cf01d8fffe7e7590729a44def265c79
Pull Request resolved: #30388
@poteto poteto deleted the gh/poteto/40/head branch July 18, 2024 20:41
@eps1lon eps1lon mentioned this pull request Jul 23, 2024
Closed
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
@felixshiftellecon
[circleci] Inline scrape_warning_messages
611b459 
This job was only being used for process_artifacts_combined in circleci
but as it was a separate job would incur the cost and time of spinning
up a new CI worker. We can simply inline this into
process_artifacts_combined.

Test plan: Download
[build.tgz](https://app.circleci.com/pipelines/github/facebook/react/57183/workflows/3b22a99e-b8a5-4c80-9682-576f24581b00/jobs/956476/artifacts)
from circleci and observe that the __test_utils__ directory is still
present.

ghstack-source-id: 8748d8fb9cf01d8fffe7e7590729a44def265c79
Pull Request resolved: facebook#30388
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
@felixshiftellecon
[circleci] Inline scrape_warning_messages
4c73c25 
This job was only being used for process_artifacts_combined in circleci
but as it was a separate job would incur the cost and time of spinning
up a new CI worker. We can simply inline this into
process_artifacts_combined.

Test plan: Download
[build.tgz](https://app.circleci.com/pipelines/github/facebook/react/57183/workflows/3b22a99e-b8a5-4c80-9682-576f24581b00/jobs/956476/artifacts)
from circleci and observe that the __test_utils__ directory is still
present.

ghstack-source-id: 8748d8fb9cf01d8fffe7e7590729a44def265c79
Pull Request resolved: facebook#30388
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpope jackpope Awaiting requested review from jackpope

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poteto @react-sizebot @facebook-github-bot