Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fiber] Ensure srcset and src are assigned last on img instances #30340

Merged
merged 2 commits into from
Jul 16, 2024

Commits on Jul 15, 2024

  1. [Fiber] Ensure srcset is last on img instances

    Safari has a behavior (bug) where when you consturct an Image in javascript if you set srcset before properties for `sizes` the brwoser will download the largest image size because it starts to load before you communicate the sizes information.
    
    https://x.com/OliverJAsh/status/1812408504444989588?t=CVHPqBaUiF5-6DBPGERTDA
    
    This change updates the dom fiber implementation to ensure that sizes is added before srcset
    gnoff committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    01ef646 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Update packages/react-dom-bindings/src/client/ReactDOMComponent.js

    Co-authored-by: Jan Kassens <jan@kassens.net>
    gnoff and kassens committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f34f75a View commit details
    Browse the repository at this point in the history