Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler][eslint] Use logger callback instead of exceptions to report eslint diagnostics #30336

Merged
merged 3 commits into from
Jul 15, 2024
Merged

[compiler][eslint] Use logger callback instead of exceptions to report eslint diagnostics #30336

merged 3 commits into from
Jul 15, 2024

Commits on Jul 15, 2024

  1. [compiler][eslint] Use logger callback instead of exceptions to repor… 

    …t eslint diagnostics

[ghstack-poisoned]
    @mofeiZ
    mofeiZ committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5c91d45 View commit details
    Browse the repository at this point in the history

  2. Update on "[compiler][eslint] Use logger callback instead of exceptio… 

    …ns to report eslint diagnostics"

[ghstack-poisoned]
    @mofeiZ
    mofeiZ committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    33e3b7c View commit details
    Browse the repository at this point in the history

  3. Update on "[compiler][eslint] Use logger callback instead of exceptio… 

    …ns to report eslint diagnostics"

---
* panicThreshold: `all_errors` -> `none`
* inject an error logger through compiler config (instead of using exceptions)

We currently report at most one lint warning per file, this lets us exhaustively report all available ones (see new
test fixture for example)

[ghstack-poisoned]
    @mofeiZ
    mofeiZ committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    988a87b View commit details
    Browse the repository at this point in the history