Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] Fix mode for generating scopes for reassignments #30321

Merged
merged 2 commits into from
Jul 16, 2024
Merged

[compiler] Fix mode for generating scopes for reassignments #30321

merged 2 commits into from
Jul 16, 2024

Commits on Jul 12, 2024

  1. [compiler] Fix mode for generating scopes for reassignments 

    We have an experimental mode where we generate scopes for simple phi values, even if they aren't subsequently mutated. This mode was incorrectly generating scope ranges, leaving the start at 0 which is invalid. The fix is to allow non-zero identifier ranges to overwrite the scope start (rather than taking the min) if the scope start is still zero.

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d88f26a View commit details
    Browse the repository at this point in the history

  2. Update on "[compiler] Fix mode for generating scopes for reassignments" 

    We have an experimental mode where we generate scopes for simple phi values, even if they aren't subsequently mutated. This mode was incorrectly generating scope ranges, leaving the start at 0 which is invalid. The fix is to allow non-zero identifier ranges to overwrite the scope start (rather than taking the min) if the scope start is still zero.

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    3f6d0e4 View commit details
    Browse the repository at this point in the history