Dedupe legacy context warnings #30299
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
Similar to other warnings about legacy APIs, only raise a warning once per component. .
| @@ -105,7 +104,7 @@ describe('ReactDOMServerIntegrationLegacyContextDisabled', () => { | |||
| <RegularFn /> | |||
| </span> | |||
| </LegacyProvider>, | |||
| render === clientRenderOnBadMarkup ? 4 : 3, | |||
| 3, | |||
There was a problem hiding this comment.
The different number of warnings originates from this PR, but didn't have a reason there. I assume it was just updated to make the test pass?
There was a problem hiding this comment.
On hydration mismatch we retry with client rendering in the new root so you got the warning again since it wasn't deduped.
That we now have the same count with good and bad markup shows that it's properly deduped 👍🏻
I'll add a comment to the original PR. There were a bunch of PR with the same pattern back then so I just forgot to mention it in each one.
| @@ -105,7 +104,7 @@ describe('ReactDOMServerIntegrationLegacyContextDisabled', () => { | |||
| <RegularFn /> | |||
| </span> | |||
| </LegacyProvider>, | |||
| render === clientRenderOnBadMarkup ? 4 : 3, | |||
| 3, | |||
There was a problem hiding this comment.
On hydration mismatch we retry with client rendering in the new root so you got the warning again since it wasn't deduped.
That we now have the same count with good and bad markup shows that it's properly deduped 👍🏻
I'll add a comment to the original PR. There were a bunch of PR with the same pattern back then so I just forgot to mention it in each one.
Similar to other warnings about legacy APIs, only raise a warning once per component.
.
Stack created with Sapling. Best reviewed with ReviewStack.