Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement onError signature for renderToMarkup #30170

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Implement onError signature for renderToMarkup #30170

merged 3 commits into from
Jul 2, 2024

Commits on Jul 1, 2024

  1. Include a component stack in prod but only lazily generate it

    @sebmarkbage
    sebmarkbage committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    476f6d0 View commit details
    Browse the repository at this point in the history

  2. Implement onError signature for renderToMarkup 

    This way we can get parent and owner stacks from the error.

This forces us to confront multiple errors and whether or not a Flight
error that ends up being unobservable needs to really reject the render.

This implements stashing of Flight errors with a digest and only errors if
they end up erroring the Fizz render too. At this point they'll have parent
stacks so we can surface those.
    @sebmarkbage
    sebmarkbage committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    4a3b5eb View commit details
    Browse the repository at this point in the history

  3. Read current stack from the client current stack during onError 

    Inside the onError event, the current owner stack is active but it's active
to the client runtime but we can access it from server runtime which is
what React.captureOwnerStack() points to.

So we need to forward this.
    @sebmarkbage
    sebmarkbage committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0db9d71 View commit details
    Browse the repository at this point in the history