Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOM] disallow client entrypoints with react-server condition #28784

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Apr 8, 2024

react-server precludes loading code that expects to be run in a client context. This includes react-dom/client react-dom/server react-dom/unstable_testing react-dom/profiling and react-dom/static

This update makes importing any of these client only entrypoints an error

`react-server` precludes loading code that expects to be run in a client context. This includes react-dom/client react-dom/server react-dom/unstable_testing react-dom/profiling and react-dom/static

This update makes importing any of these client only entrypoints an error
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 8, 2024
@react-sizebot
Copy link

Comparing: f62cf8c...7d47918

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.83 kB 168.83 kB = 52.71 kB 52.71 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 170.64 kB 170.64 kB = 53.24 kB 53.24 kB
facebook-www/ReactDOM-prod.classic.js = 590.71 kB 590.71 kB = 103.88 kB 103.88 kB
facebook-www/ReactDOM-prod.modern.js = 566.64 kB 566.64 kB = 100.07 kB 100.07 kB
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 7d47918

@gnoff gnoff merged commit 556a087 into facebook:main Apr 8, 2024
38 checks passed
@gnoff gnoff deleted the no-client-in-react-server branch April 8, 2024 22:37
gnoff added a commit that referenced this pull request Apr 8, 2024
Missed some files for the react-server disallow client change in #28784
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
`react-server` precludes loading code that expects to be run in a client
context. This includes react-dom/client react-dom/server
react-dom/unstable_testing react-dom/profiling and react-dom/static

This update makes importing any of these client only entrypoints an
error
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
Missed some files for the react-server disallow client change in #28784
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
`react-server` precludes loading code that expects to be run in a client
context. This includes react-dom/client react-dom/server
react-dom/unstable_testing react-dom/profiling and react-dom/static

This update makes importing any of these client only entrypoints an
error
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
Missed some files for the react-server disallow client change in #28784
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…ok#28784)

`react-server` precludes loading code that expects to be run in a client
context. This includes react-dom/client react-dom/server
react-dom/unstable_testing react-dom/profiling and react-dom/static

This update makes importing any of these client only entrypoints an
error
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Missed some files for the react-server disallow client change in facebook#28784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants