Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back out #28476 and #28458 #28653

Closed
wants to merge 1 commit into from
Closed

Back out #28476 and #28458 #28653

wants to merge 1 commit into from

Conversation

kassens
Copy link
Member

@kassens kassens commented Mar 26, 2024

www had to revert the flag. We might need to wait on this until that is sorted out.

Back out "Move Hydration Warnings from the DOM Config into the Fiber reconciliation (#28476)"
Original commit changeset: 4b8dfd6

Back out "Remove enableClientRenderFallbackOnTextMismatch flag (#28458)"
Original commit changeset: 84c84d7

Back out "Move Hydration Warnings from the DOM Config into the Fiber reconciliation (facebook#28476)"

Original commit changeset: 4b8dfd6

Back out "Remove enableClientRenderFallbackOnTextMismatch flag (facebook#28458)"

Original commit changeset: 84c84d7
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 26, 2024
@react-sizebot
Copy link

Comparing: 4b8dfd6...0f3b777

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.01% 175.92 kB 175.94 kB = 54.70 kB 54.54 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.01% 172.41 kB 172.42 kB = 53.84 kB 53.72 kB
facebook-www/ReactDOM-prod.classic.js +0.18% 589.78 kB 590.84 kB = 103.78 kB 103.76 kB
facebook-www/ReactDOM-prod.modern.js +0.19% 573.30 kB 574.36 kB = 100.82 kB 100.83 kB
test_utils/ReactAllWarnings.js Deleted 65.27 kB 0.00 kB Deleted 16.17 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js +0.55% 112.51 kB 113.13 kB +0.25% 35.00 kB 35.09 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.min.js +0.54% 114.25 kB 114.87 kB +0.32% 35.40 kB 35.51 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.min.js +0.54% 114.28 kB 114.90 kB +0.31% 35.43 kB 35.54 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js +0.51% 121.55 kB 122.17 kB +0.26% 37.34 kB 37.43 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.min.js +0.50% 123.30 kB 123.92 kB +0.28% 37.75 kB 37.86 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js +0.50% 123.33 kB 123.94 kB +0.29% 37.77 kB 37.88 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,679.34 kB 1,675.77 kB = 333.39 kB 332.91 kB
facebook-www/ReactDOM-dev.classic.js = 1,657.82 kB 1,654.25 kB = 328.84 kB 328.37 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,649.43 kB 1,645.87 kB = 328.00 kB 327.48 kB
facebook-www/ReactDOM-dev.modern.js = 1,627.96 kB 1,624.40 kB = 323.48 kB 322.96 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js = 925.53 kB 923.43 kB = 197.85 kB 197.24 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js = 925.51 kB 923.40 kB = 197.83 kB 197.22 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 921.72 kB 919.61 kB = 197.02 kB 196.42 kB
oss-stable/react-dom/umd/react-dom.development.js = 1,381.02 kB 1,377.20 kB = 293.25 kB 292.48 kB
oss-stable-semver/react-dom/umd/react-dom.development.js = 1,381.00 kB 1,377.17 kB = 293.22 kB 292.45 kB
oss-stable/react-dom/cjs/react-dom.development.js = 1,317.53 kB 1,313.82 kB = 290.26 kB 289.48 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js = 1,317.50 kB 1,313.80 kB = 290.22 kB 289.44 kB
oss-experimental/react-dom/umd/react-dom.development.js = 1,371.90 kB 1,368.02 kB = 291.68 kB 290.91 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,326.45 kB 1,322.70 kB = 292.94 kB 292.20 kB
oss-experimental/react-dom/cjs/react-dom.development.js = 1,308.66 kB 1,304.90 kB = 288.71 kB 287.92 kB
test_utils/ReactAllWarnings.js Deleted 65.27 kB 0.00 kB Deleted 16.17 kB 0.00 kB

Generated by 🚫 dangerJS against 0f3b777

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is replaced by #28655, which basically adds the flag back, but allows us to get the added benefits of the hydration diffs to debug more issues

@kassens kassens closed this Mar 28, 2024
@kassens kassens deleted the pr28653 branch March 28, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants