Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup alwaysThrottleDisappearingFallbacks Flag #28639

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Cleanup alwaysThrottleDisappearingFallbacks Flag #28639

merged 1 commit into from
Mar 26, 2024

Conversation

yungsters
Copy link
Contributor

Summary

After realizing that this feature flag is entangled with alwaysThrottleRetries, we're going to undo #28550

How did you test this change?

$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric

@react-sizebot
Copy link

Comparing: 5a75f9e...4d3e935

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.93 kB 176.93 kB = 54.95 kB 54.95 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.36 kB 173.36 kB = 54.08 kB 54.08 kB
facebook-www/ReactDOM-prod.classic.js = 595.27 kB 595.15 kB = 104.55 kB 104.52 kB
facebook-www/ReactDOM-prod.modern.js = 578.53 kB 578.41 kB = 101.57 kB 101.54 kB
test_utils/ReactAllWarnings.js Deleted 65.49 kB 0.00 kB Deleted 16.16 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 65.49 kB 0.00 kB Deleted 16.16 kB 0.00 kB

Generated by 🚫 dangerJS against 4d3e935

This was referenced Mar 26, 2024
Closed
Closed
@yungsters yungsters merged commit 6fd0cb9 into facebook:main Mar 26, 2024
38 checks passed
@yungsters yungsters deleted the flags branch March 26, 2024 17:01
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
@yungsters
Cleanup alwaysThrottleDisappearingFallbacks Flag (#28639)
ed3c6af 
## Summary

After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550

## How did you test this change?

```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```

DiffTrain build for [6fd0cb9](6fd0cb9)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@yungsters @AndyPengc12
Cleanup alwaysThrottleDisappearingFallbacks Flag (facebook#28639)
6b71243 
## Summary

After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
facebook#28550

## How did you test this change?

```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@yungsters
Cleanup alwaysThrottleDisappearingFallbacks Flag (#28639)
64cc527 
## Summary

After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550

## How did you test this change?

```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```

DiffTrain build for commit 6fd0cb9.
This was referenced Apr 24, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yungsters @react-sizebot @rickhanlonii @facebook-github-bot