Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove method name prefix from warnings and errors #28432

Merged
merged 1 commit into from
Feb 23, 2024

Commits on Feb 23, 2024

  1. Remove method name prefix from warnings and errors

    This pattern is a petpeeve of mine. I don't consider this best practice
    and so most don't have these prefixes. Very inconsistent.
    
    At best this is useless and noisey that you have to parse because the
    information is also in the stack trace.
    
    At worse these are misleading because they'rehighlighting something
    internal (like validateDOMNesting) which even suggests an internal bug.
    Even the ones public to React aren't necessarily what you called because
    you might be calling a wrapper around it.
    
    That would be properly reflected in a stack trace - which can also properly
    ignore list so that the first stack you see is your callsite,
    
    Which might be like render() in react-testing-library rather than createRoot()
    for example.
    sebmarkbage committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    8515602 View commit details
    Browse the repository at this point in the history