Setup for aligning React Native Feature Flags #28425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: aaa4acb...c519244 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
rickhanlonii
approved these changes
Feb 23, 2024
| @@ -35,7 +35,7 @@ export const disableIEWorkarounds = true; | |||
| export const enableScopeAPI = false; | |||
| export const enableCreateEventHandleAPI = false; | |||
| export const enableSuspenseCallback = false; | |||
| export const disableLegacyContext = false; | |||
| export const disableLegacyContext = true; // TODO: Verify safety of enabling. | |||
There was a problem hiding this comment.
Might want to make this dynamic
yungsters
added a commit
that referenced
this pull request
Mar 8, 2024
## Summary This PR is a subset of #28425, which only includes the feature flags that will be configured as "always on" (i.e. not "dynamic"). The following list summarizes the feature flag changes: * RN FB * Always Enable * enableCache * enableCustomElementPropertySupport * RN OSS * Always Enable * disableLegacyContext * enableCache * enableCustomElementPropertySupport * RN Test * Always Enable * disableModulePatternComponents * enableCustomElementPropertySupport ## How did you test this change? Ran the following successfully: ``` $ yarn test $ yarn flow native $ yarn flow fabric ```
yungsters
added a commit
that referenced
this pull request
Mar 9, 2024
## Summary This PR is a subset of #28425, which only includes the feature flags that will be configured as dynamic. The following list summarizes the feature flag changes: * RN FB * Change to Dynamic * consoleManagedByDevToolsDuringStrictMode * enableAsyncActions * enableDeferRootSchedulingToMicrotask * enableRenderableContext * useModernStrictMode ## How did you test this change? Ran the following successfully: ``` $ yarn test $ yarn flow native $ yarn flow fabric ```
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
## Summary This PR is a subset of facebook#28425, which only includes the feature flags that will be configured as "always on" (i.e. not "dynamic"). The following list summarizes the feature flag changes: * RN FB * Always Enable * enableCache * enableCustomElementPropertySupport * RN OSS * Always Enable * disableLegacyContext * enableCache * enableCustomElementPropertySupport * RN Test * Always Enable * disableModulePatternComponents * enableCustomElementPropertySupport ## How did you test this change? Ran the following successfully: ``` $ yarn test $ yarn flow native $ yarn flow fabric ```
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
## Summary This PR is a subset of facebook#28425, which only includes the feature flags that will be configured as dynamic. The following list summarizes the feature flag changes: * RN FB * Change to Dynamic * consoleManagedByDevToolsDuringStrictMode * enableAsyncActions * enableDeferRootSchedulingToMicrotask * enableRenderableContext * useModernStrictMode ## How did you test this change? Ran the following successfully: ``` $ yarn test $ yarn flow native $ yarn flow fabric ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Configures a bunch of the React Native feature flags in an effort to begin aligning them to React DOM.
The following list summarizes the feature flag changes at a high level:
How did you test this change?
Ran the following successfully: