Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ReactDOMServerSuspense-test to not use legacy rendering APIs #28251

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Update ReactDOMServerSuspense-test to not use legacy rendering APIs #28251

merged 1 commit into from
Feb 6, 2024

Commits on Feb 6, 2024

  1. Update ReactDOMServerSuspense-test to not use legacy rendering APIs 

    Updates ReactDOMServerSuspense-test to not use legacy rendering APIs. Previously this test was relying on suspending in the legacy renderer to throw during server rendering as well as during client rendering. With the advent of concurrent roots on the client however this doesn't make sense and it only makes sense on the server when using legacy apis like renderToString.

I have removed the use of ReactDOMServerIntegrationTestUtils in this test suite and limited the tests to server tests using renderToString to keep as much parity with what was being tested before while dropping anything that no longer makes sense to assert on concurrent client roots
    @gnoff
    gnoff committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    be76c13 View commit details
    Browse the repository at this point in the history