[Flight] Implement react-server-dom-turbopack
#27315
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
gnoff
force-pushed
the
react-server-dom-turbopack
branch
from
9abfa5c
to
276dfe7
Compare
gnoff
force-pushed
the
react-server-dom-turbopack
branch
9 times, most recently
from
1895b38
to
4797960
Compare
gnoff
force-pushed
the
react-server-dom-turbopack
branch
3 times, most recently
from
cf830a4
to
1559b0d
Compare
gnoff
force-pushed
the
react-server-dom-turbopack
branch
from
1559b0d
to
21f23a4
Compare
gnoff
force-pushed
the
react-server-dom-turbopack
branch
from
21f23a4
to
d79113d
Compare
React upstream changes: - facebook/react#27439 - facebook/react#26763 - facebook/react#27434 - facebook/react#27433 - facebook/react#27424 - facebook/react#27428 - facebook/react#27427 - facebook/react#27315 - facebook/react#27314 - facebook/react#27400 - facebook/react#27421 - facebook/react#27419 - facebook/react#27418
|
@gnoff @sebmarkbage instead of creating specific versions of |
|
For performance. Each binding package can implement a strategy that is optimized for the bundler in a way that can’t be don’t with a general load function. For instance the wire format of chunks is not the same between webpack and turbopack but if we used a single package we would need to encode all the required data to satisfy any and all bundles from a single package. The implementations of turbopack and webpack look substantially similar because turbopack made some changes recently that happen to make it work more like webpack but a few months ago this package would have looked quite a bit different. |
|
Thanks for the reasoning @gnoff! If all of this functionality will be ever supported other than Next.js, then I suppose there will be a generic version of |
|
There is a PR open for a vite package that we are looking to help land soon. That should probably work better for you when it is available |
Today when we hydrate an SSR'd RSC response on the client we encounter import chunks which initiate code loading for client components. However we only start fetching these chunks after hydration has begun which is necessarily after the initial chunks for the entrypoint have loaded. React has upstream changes that need to land which will preinitialize the rendered chunks for all client components used during the SSR pass. This will cause a `<script async="" src... />` tag to be emitted in the head for each chunk we need to load during hydration which allows the browser to start fetching these resources even before the entrypoint has started to execute. Additionally the implementation for webpack and turbopack is different enough that there will be a new `react-server-dom-turbopack` package in the React repo which should be used when using Turbopack with Next. This PR also removes a number of patches to React src that proxy loading (`__next_chunk_load__`) and bundler requires (`__next_require__`) through the `globalThis` object. Now the react packages can be fully responsible for implementing chunk loading and all Next needs to do is supply the necessary information such as chunk prefix and crossOrigin attributes necessary for this loading. This information is produced as part of the client-manifest by either a Webpack plugin or Turbopack. Additionally any modifications to the chunk filename that were previously done at runtime need to be made in the manifest itself now. This means we need to encode the deployment id for skew protection and encode the filename to make it match our static path matching (and resolutions on s3) when using `[` and `]` segment characters. There are a few followup items to consider in later PRs 1. we currently bundle a node and edge version of react-server-dom-webpack/client. The node version has an implementation for busboy whereas the edge version does not. Next is currently configured to use busboy when handling a fetch action sent as multipart with a node runtime. Ideally we'd only bundle the one platform we are buliding for but some additional refactoring to support better forking is possibly required here This PR also updates react from 09285d5a7 to d900fadbf. ### React upstream changes - facebook/react#27439 - facebook/react#26763 - facebook/react#27434 - facebook/react#27433 - facebook/react#27424 - facebook/react#27428 - facebook/react#27427 - facebook/react#27315 - facebook/react#27314 - facebook/react#27400 - facebook/react#27421 - facebook/react#27419 - facebook/react#27418
stacked on facebook#27314 Turbopack requires a different module loading strategy than Webpack and as such this PR implements a new package `react-server-dom-turbopack` which largely follows the `react-server-dom-webpack` but is implemented for this new bundler
stacked on #27314
Turbopack requires a different module loading strategy than Webpack and as such this PR implements a new package
react-server-dom-turbopackwhich largely follows thereact-server-dom-webpackbut is implemented for this new bundler