Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert more Suspense tests to use act #26602

Merged
merged 1 commit into from
Apr 11, 2023

Commits on Apr 11, 2023

  1. Convert more Suspense tests to use act

    Many of our Suspense-related tests were written before the `act` API was
    introduced, and use the lower level `waitFor` helpers instead. So they
    are less resilient to changes in implementation details than they
    could be.
    
    This converts some of our test suite to use `act` in more places. I
    found these while working on a PR to expand our fallback throttling
    mechanism to include all renders that result from a promise resolving,
    even if there are no more fallbacks in the tree. This isn't all the
    affected tests, just some of them — I'll be sharding the changes across
    multiple PRs.
    acdlite committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    fa8bfa9 View commit details
    Browse the repository at this point in the history