Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal act: Call scope function after an async gap #26347

Merged
merged 1 commit into from
Mar 8, 2023

Commits on Mar 8, 2023

  1. Internal act: Call scope function after an async gap

    This adds an async gap to our internal implementation of `act` (the one
    used by our repo, not the public API). Rather than call the provided
    scope function synchronously when `act` is called, we call it in a
    separate async task. This is an extra precaution to ensure that our
    tests do not accidentally rely on work being queued synchronously,
    because that is an implementation detail that we should be allowed to
    change. We don't do this in the public version of `act`, though we maybe
    should in the future, for the same rationale. That might be tricky,
    though, because it could break existing tests.
    acdlite committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    ffabc0c View commit details
    Browse the repository at this point in the history