Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: specify Node.js 16 as minimum for dev #26343

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Conversation

kassens
Copy link
Member

@kassens kassens commented Mar 8, 2023

Test Plan:
(using node 19) as that's what I'm adding)

  • yarn build
  • yarn test

@kassens kassens requested a review from gnoff March 8, 2023 15:59
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 8, 2023
@react-sizebot
Copy link

react-sizebot commented Mar 8, 2023

Comparing: 161f6ae...f23ffff

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 156.70 kB 156.70 kB = 49.58 kB 49.58 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 158.70 kB 158.70 kB = 50.25 kB 50.25 kB
facebook-www/ReactDOM-prod.classic.js = 538.92 kB 538.92 kB = 95.86 kB 95.86 kB
facebook-www/ReactDOM-prod.modern.js = 522.78 kB 522.78 kB = 93.55 kB 93.55 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against f23ffff

Copy link
Collaborator

@gnoff gnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s also update .nvmrc to v16

I generally think it’s a good idea that we use the oldest supported version of node by default so that we detect these breakages automatically

@kassens
Copy link
Member Author

kassens commented Mar 8, 2023

I generally think it’s a good idea that we use the oldest supported version of node by default so that we detect these breakages automatically

Do you mean for things like server rendering? If that's the reason to use an old version of node locally, we might instead want to enable at least 1 CI job for the old node version?

@kassens kassens merged commit 8c10062 into facebook:main Mar 8, 2023
@kassens kassens deleted the node16 branch March 8, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants