Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal API only] Delete non-awaited form of act #26339

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[Internal API only] Delete non-awaited form of act #26339

merged 1 commit into from
Mar 8, 2023

Commits on Mar 8, 2023

  1. [Internal API only] Delete non-awaited form of act 

    **This commit only affects the internal version of `act` that we use in
this repo. The public `act` API is unaffected, for now.**

We should always await the result of an `act` call so that any work
queued in a microtask has a chance to flush. Neglecting to do this can
cause us to miss bugs when testing React behavior.

I codemodded all the existing `act` callers in previous PRs.
    @acdlite
    acdlite committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    edde672 View commit details
    Browse the repository at this point in the history