Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy from build to node_modules instead of linking to builds #26210

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Feb 21, 2023

Using the link: protocol to create a dependency doesn't work when we edit the package.json to lock the version to a specific version. It didn't really work before neither, it was just that yarn installed an existing scheduler dependency from npm instead of using the built one.

So I'm updating all the fixture to use the technique where we copy files instead.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 21, 2023
@react-sizebot
Copy link

react-sizebot commented Feb 21, 2023

Comparing: c8d4eed...53f7c6b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.55 kB 154.55 kB = 48.79 kB 48.79 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.54 kB 156.54 kB = 49.45 kB 49.45 kB
facebook-www/ReactDOM-prod.classic.js = 531.11 kB 531.11 kB = 94.64 kB 94.64 kB
facebook-www/ReactDOM-prod.modern.js = 515.07 kB 515.07 kB = 92.17 kB 92.17 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 53f7c6b

@sebmarkbage sebmarkbage merged commit 0a76fb9 into facebook:main Feb 21, 2023
github-actions bot pushed a commit that referenced this pull request Feb 21, 2023
Using the `link:` protocol to create a dependency doesn't work when we
edit the `package.json` to lock the version to a specific version. It
didn't really work before neither, it was just that `yarn` installed an
existing `scheduler` dependency from npm instead of using the built one.

So I'm updating all the fixture to use the technique where we copy files
instead.

DiffTrain build for commit 0a76fb9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants