Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle info, group, and groupCollapsed in Strict Mode logging #25172

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Handle info, group, and groupCollapsed in Strict Mode logging #25172

merged 3 commits into from
Sep 6, 2022
+83 −2

Commits on Sep 1, 2022

  1. Handle info, group, and groupCollapsed in Strict Mode logging 

    While working on the new Next.js router which heavily relies on useReducer I noticed that `group` and `groupCollapsed` which both take labels were showing as-is in the console for the second render/dispatch in Strict Mode logs. While looking at the code I found that `info` was also not instrumented.

I've added additional handling for:
- `info`
- `group`
- `groupCollapsed`
    @timneutkens
    timneutkens committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    d64b33b View commit details
    Browse the repository at this point in the history

  2. Remove console.log

    @timneutkens
    timneutkens committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    bae72bc View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @timneutkens
    timneutkens committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    da83aa9 View commit details
    Browse the repository at this point in the history