Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React DevTools 4.24.4 -> 4.24.5 #24482

Closed
wants to merge 1 commit into from
Closed

React DevTools 4.24.4 -> 4.24.5 #24482

wants to merge 1 commit into from

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented May 3, 2022

No description provided.

@bvaughn bvaughn requested review from gaearon and mondaychen May 3, 2022 12:46
lunaruan
lunaruan suggested changes May 3, 2022
View reviewed changes
Copy link
Contributor

@lunaruan lunaruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a change in the React shared package that imports ReactFeatureFlags into the React devtools. We're looking at a fix but we shouldn't release until then. We also want to add a bugfix to the console suppression code first.

@bvaughn
Copy link
Contributor Author

bvaughn commented May 3, 2022

Sure thing.

@bvaughn bvaughn closed this May 3, 2022
@bvaughn bvaughn deleted the devtools-4_24_5 branch May 3, 2022 16:47
@lunaruan
Copy link
Contributor

lunaruan commented May 3, 2022

You should be able to land this now

@bvaughn
Copy link
Contributor Author

bvaughn commented May 5, 2022

Thank you. Once you and @mondaychen have a chance to decide on whether #24501 is worth landing or not, I'll re-run the changelog generation script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunaruan lunaruan lunaruan requested changes

@gaearon gaearon Awaiting requested review from gaearon

@mondaychen mondaychen Awaiting requested review from mondaychen

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bvaughn @lunaruan @facebook-github-bot