Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevTools Store emits errors before throwing #21426

Merged
merged 1 commit into from
May 4, 2021
Merged

DevTools Store emits errors before throwing #21426

merged 1 commit into from
May 4, 2021

Commits on May 4, 2021

  1. DevTools Store emits errors before throwing 

    The Store should never throw an Error without also emitting an event. Otherwise Store errors will be invisible to users, but the downstream errors they cause will be reported as bugs. (For example, github.com/facebook/issues/21402)

Emitting an error event allows the ErrorBoundary to show the original error.

Throwing is still valuable for local development and for unit testing the Store itself.
    Brian Vaughn committed May 4, 2021
    Configuration menu
    Copy the full SHA
    ab302c8 View commit details
    Browse the repository at this point in the history