Sync ReactNativeTypes from RN repo to React #21014
Conversation
|
Comparing: f8979e0...ad6145d Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
| @@ -126,7 +125,4 @@ class ReactNativeFiberHostComponent { | |||
| } | |||
| } | |||
|
|
|||
| // eslint-disable-next-line no-unused-expressions | |||
| (ReactNativeFiberHostComponent.prototype: NativeMethods); | |||
There was a problem hiding this comment.
These casts are actually quite important. They make sure that Paper host components and Fabric host components have the same API, and that they match the flow types that products use.
If the issue is that the now exact NativeMethods no longer matches the inexact class *HostComponent does this work?
*HostComponent: {...NativeMethods, ...}
Essentially saying explicitly that it will include NativeMethods, as well as other things.
There was a problem hiding this comment.
That doesn't work, nor does {| ... |} and a few other things I tried
There was a problem hiding this comment.
Maybe what I said but wrapped in $ReadOnly.
$ReadOnly<{...NativeMethods, ...}>
Summary
Syncs over changes RN edited directly.
The same as #21012 but with some $FlowFixMes and some Flow casts removed.
This might not be the right approach, I'll need some feedback.
Test Plan
yarn flow fabric && yarn flow native && yarn lint && yarn test